Title: [246015] trunk/LayoutTests
- Revision
- 246015
- Author
- [email protected]
- Date
- 2019-06-01 13:19:18 -0700 (Sat, 01 Jun 2019)
Log Message
Web Inspector: Canvas: in tests don't manually stop recording if a frame count is specified
https://bugs.webkit.org/show_bug.cgi?id=198457
<rdar://problem/48248697>
Reviewed by Joseph Pecoraro.
If a `frameCount` is specified, the recording will stop by itself, so if we hit the
`LastFrame`, there's no need to manually stop the recording at that point. Otherwise,
stopping it early may cause the recording to think that the last frame is incomplete.
* inspector/canvas/resources/recording-utilities.js:
* inspector/canvas/recording-webgl-snapshots.html:
* inspector/canvas/recording-webgl2-snapshots.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (246014 => 246015)
--- trunk/LayoutTests/ChangeLog 2019-06-01 16:19:40 UTC (rev 246014)
+++ trunk/LayoutTests/ChangeLog 2019-06-01 20:19:18 UTC (rev 246015)
@@ -1,3 +1,19 @@
+2019-06-01 Devin Rousso <[email protected]>
+
+ Web Inspector: Canvas: in tests don't manually stop recording if a frame count is specified
+ https://bugs.webkit.org/show_bug.cgi?id=198457
+ <rdar://problem/48248697>
+
+ Reviewed by Joseph Pecoraro.
+
+ If a `frameCount` is specified, the recording will stop by itself, so if we hit the
+ `LastFrame`, there's no need to manually stop the recording at that point. Otherwise,
+ stopping it early may cause the recording to think that the last frame is incomplete.
+
+ * inspector/canvas/resources/recording-utilities.js:
+ * inspector/canvas/recording-webgl-snapshots.html:
+ * inspector/canvas/recording-webgl2-snapshots.html:
+
2019-05-31 Wenson Hsieh <[email protected]>
Make tests that use UIHelper more robust under certain configurations
Modified: trunk/LayoutTests/inspector/canvas/recording-webgl-snapshots.html (246014 => 246015)
--- trunk/LayoutTests/inspector/canvas/recording-webgl-snapshots.html 2019-06-01 16:19:40 UTC (rev 246014)
+++ trunk/LayoutTests/inspector/canvas/recording-webgl-snapshots.html 2019-06-01 20:19:18 UTC (rev 246015)
@@ -100,7 +100,7 @@
name: "Canvas.recordingWebGL.snapshots",
description: "Check that the snapshot taken after each visual action is different.",
test(resolve, reject) {
- startRecording(WI.Canvas.ContextType.WebGL, resolve, reject, {checkForContentChange: true});
+ startRecording(WI.Canvas.ContextType.WebGL, resolve, reject, {frameCount: 1, checkForContentChange: true});
},
timeout: -1,
});
Modified: trunk/LayoutTests/inspector/canvas/recording-webgl2-snapshots.html (246014 => 246015)
--- trunk/LayoutTests/inspector/canvas/recording-webgl2-snapshots.html 2019-06-01 16:19:40 UTC (rev 246014)
+++ trunk/LayoutTests/inspector/canvas/recording-webgl2-snapshots.html 2019-06-01 20:19:18 UTC (rev 246015)
@@ -102,7 +102,7 @@
name: "Canvas.recordingWebGL2.snapshots",
description: "Check that the snapshot taken after each visual action is different.",
test(resolve, reject) {
- startRecording(WI.Canvas.ContextType.WebGL2, resolve, reject, {checkForContentChange: true});
+ startRecording(WI.Canvas.ContextType.WebGL2, resolve, reject, {frameCount: 1, checkForContentChange: true});
},
timeout: -1,
});
Modified: trunk/LayoutTests/inspector/canvas/resources/recording-utilities.js (246014 => 246015)
--- trunk/LayoutTests/inspector/canvas/resources/recording-utilities.js 2019-06-01 16:19:40 UTC (rev 246014)
+++ trunk/LayoutTests/inspector/canvas/resources/recording-utilities.js 2019-06-01 20:19:18 UTC (rev 246015)
@@ -107,9 +107,10 @@
.then((event) => {
lastFrame = true;
- if (canvas.recordingActive)
- CanvasAgent.stopRecording(canvas.identifier).catch(reject);
- else {
+ if (canvas.recordingActive) {
+ if (!frameCount)
+ CanvasAgent.stopRecording(canvas.identifier).catch(reject);
+ } else {
InspectorTest.evaluateInPage(`cancelActions()`)
.then(() => {
if (swizzled)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
