Title: [246032] trunk/Source/WebKit
- Revision
- 246032
- Author
- [email protected]
- Date
- 2019-06-03 02:43:41 -0700 (Mon, 03 Jun 2019)
Log Message
REGRESSION(r240862) [WinCairo][WK2] position:fixed elements don't show
https://bugs.webkit.org/show_bug.cgi?id=198478
Reviewed by Carlos Garcia Campos.
All position:fixed elements didn't show in WinCairo WebKit2 since
r240862 which turns acceleratedCompositingEnabled on for WebKit2.
WinCairo WebKit2 doesn't have accelerated compositing support yet.
Let's do the same with GTK port.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Conditioned out the code
enabling acceleratedCompositingEnabled for PLATFORM(WIN).
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (246031 => 246032)
--- trunk/Source/WebKit/ChangeLog 2019-06-03 09:29:39 UTC (rev 246031)
+++ trunk/Source/WebKit/ChangeLog 2019-06-03 09:43:41 UTC (rev 246032)
@@ -1,3 +1,19 @@
+2019-06-03 Fujii Hironori <[email protected]>
+
+ REGRESSION(r240862) [WinCairo][WK2] position:fixed elements don't show
+ https://bugs.webkit.org/show_bug.cgi?id=198478
+
+ Reviewed by Carlos Garcia Campos.
+
+ All position:fixed elements didn't show in WinCairo WebKit2 since
+ r240862 which turns acceleratedCompositingEnabled on for WebKit2.
+ WinCairo WebKit2 doesn't have accelerated compositing support yet.
+ Let's do the same with GTK port.
+
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::updatePreferences): Conditioned out the code
+ enabling acceleratedCompositingEnabled for PLATFORM(WIN).
+
2019-06-03 Carlos Garcia Campos <[email protected]>
REGRESSION(r244182): [CoordinatedGraphics] Related view doesn't receive graphic updates
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (246031 => 246032)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2019-06-03 09:29:39 UTC (rev 246031)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2019-06-03 09:43:41 UTC (rev 246032)
@@ -3519,7 +3519,7 @@
Settings& settings = m_page->settings();
-#if !PLATFORM(GTK)
+#if !PLATFORM(GTK) && !PLATFORM(WIN)
if (!settings.acceleratedCompositingEnabled()) {
RELEASE_LOG_IF_ALLOWED("%p - WebPage - acceleratedCompositingEnabled setting was false. WebKit cannot function in this mode; changing setting to true", this);
settings.setAcceleratedCompositingEnabled(true);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
