Title: [246068] trunk/Source/WebKit
- Revision
- 246068
- Author
- [email protected]
- Date
- 2019-06-04 09:11:38 -0700 (Tue, 04 Jun 2019)
Log Message
REGRESSION (r245913) [ Debug ] ASSERTION FAILED: m_swConnectionsByIdentifier.contains(connection.serverConnectionIdentifier()) Layout Test http/wpt/service-workers/update-service-worker.https.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=198434
<rdar://problem/51313917>
Reviewed by Alex Christensen.
Iterate through the connectionID-based connection map instead of the sessionID-based map to notify them their connection is lost.
* WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didClose):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (246067 => 246068)
--- trunk/Source/WebKit/ChangeLog 2019-06-04 15:52:25 UTC (rev 246067)
+++ trunk/Source/WebKit/ChangeLog 2019-06-04 16:11:38 UTC (rev 246068)
@@ -1,3 +1,16 @@
+2019-06-04 Youenn Fablet <[email protected]>
+
+ REGRESSION (r245913) [ Debug ] ASSERTION FAILED: m_swConnectionsByIdentifier.contains(connection.serverConnectionIdentifier()) Layout Test http/wpt/service-workers/update-service-worker.https.html is a flaky crash
+ https://bugs.webkit.org/show_bug.cgi?id=198434
+ <rdar://problem/51313917>
+
+ Reviewed by Alex Christensen.
+
+ Iterate through the connectionID-based connection map instead of the sessionID-based map to notify them their connection is lost.
+
+ * WebProcess/Network/NetworkProcessConnection.cpp:
+ (WebKit::NetworkProcessConnection::didClose):
+
2019-06-04 Chris Dumez <[email protected]>
[iOS] UIProcess' background task expiration handler may get called after the app is foreground again
Modified: trunk/Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp (246067 => 246068)
--- trunk/Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp 2019-06-04 15:52:25 UTC (rev 246067)
+++ trunk/Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp 2019-06-04 16:11:38 UTC (rev 246068)
@@ -195,8 +195,8 @@
#endif
#if ENABLE(SERVICE_WORKER)
- m_swConnectionsByIdentifier.clear();
- for (auto& connection : m_swConnectionsBySession.values())
+ auto connections = std::exchange(m_swConnectionsByIdentifier, { });
+ for (auto& connection : connections.values())
connection->connectionToServerLost();
#endif
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
