Title: [246080] trunk/Tools
- Revision
- 246080
- Author
- [email protected]
- Date
- 2019-06-04 14:27:07 -0700 (Tue, 04 Jun 2019)
Log Message
[ews-build] Do not display unnecessary steps in the Buildbot build page UI
https://bugs.webkit.org/show_bug.cgi?id=198218
<rdar://problem/51104544>
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-build/steps.py:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (246079 => 246080)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-06-04 20:54:31 UTC (rev 246079)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-06-04 21:27:07 UTC (rev 246080)
@@ -139,6 +139,9 @@
d = self.downloadFileContentToWorker('.buildbot-diff', patch)
d.addCallback(lambda res: shell.ShellCommand.start(self))
+ def hideStepIf(self, results, step):
+ return results == SUCCESS and self.getProperty('validated', '') == False
+
def getResultSummary(self):
if self.results != SUCCESS:
return {u'step': u'Patch does not apply'}
@@ -368,6 +371,7 @@
if obsolete == -1 or review_denied == -1 or bug_closed == -1:
self.finished(WARNINGS)
+ self.setProperty('validated', False)
return None
self._addToLog('stdio', 'Bug is open.\nPatch is not obsolete.\nPatch is not marked r-.\n')
@@ -809,6 +813,9 @@
return super(TransferToS3, self).finished(results)
+ def hideStepIf(self, results, step):
+ return results == SUCCESS and self.getProperty('validated', '') == False
+
def getResultSummary(self):
if self.results != SUCCESS:
return {u'step': u'Failed to transfer archive to S3'}
Modified: trunk/Tools/ChangeLog (246079 => 246080)
--- trunk/Tools/ChangeLog 2019-06-04 20:54:31 UTC (rev 246079)
+++ trunk/Tools/ChangeLog 2019-06-04 21:27:07 UTC (rev 246080)
@@ -1,3 +1,13 @@
+2019-06-04 Aakash Jain <[email protected]>
+
+ [ews-build] Do not display unnecessary steps in the Buildbot build page UI
+ https://bugs.webkit.org/show_bug.cgi?id=198218
+ <rdar://problem/51104544>
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-build/steps.py:
+
2019-06-04 Sihui Liu <[email protected]>
WKWebsiteDataStore API fails to fetch web storage data for non-persistent data store
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
