Title: [246085] trunk/Tools
- Revision
- 246085
- Author
- [email protected]
- Date
- 2019-06-04 15:56:37 -0700 (Tue, 04 Jun 2019)
Log Message
REGRESSION (r244557): Leak of WKNSString in WTR::runOpenPanel() while running WebKit layout tests
<https://webkit.org/b/198538>
<rdar://problem/51407719>
Reviewed by Darin Adler.
* WebKitTestRunner/TestController.cpp:
(WTR::runOpenPanel): Use adoptWK() to fix the leak.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (246084 => 246085)
--- trunk/Tools/ChangeLog 2019-06-04 22:08:43 UTC (rev 246084)
+++ trunk/Tools/ChangeLog 2019-06-04 22:56:37 UTC (rev 246085)
@@ -1,3 +1,14 @@
+2019-06-04 David Kilzer <[email protected]>
+
+ REGRESSION (r244557): Leak of WKNSString in WTR::runOpenPanel() while running WebKit layout tests
+ <https://webkit.org/b/198538>
+ <rdar://problem/51407719>
+
+ Reviewed by Darin Adler.
+
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::runOpenPanel): Use adoptWK() to fix the leak.
+
2019-06-04 Aakash Jain <[email protected]>
[ews-app] Add authentication while fetching bugs
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (246084 => 246085)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2019-06-04 22:08:43 UTC (rev 246084)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2019-06-04 22:56:37 UTC (rev 246085)
@@ -204,16 +204,16 @@
WKTypeRef firstItem = WKArrayGetItemAtIndex(fileURLs, 0);
#if PLATFORM(IOS_FAMILY)
- WKStringRef displayString = WKURLCopyLastPathComponent(static_cast<WKURLRef>(firstItem));
+ auto displayString = adoptWK(WKURLCopyLastPathComponent(static_cast<WKURLRef>(firstItem)));
WKDataRef mediaIcon = TestController::singleton().openPanelFileURLsMediaIcon();
if (mediaIcon) {
if (WKOpenPanelParametersGetAllowsMultipleFiles(parameters)) {
- WKOpenPanelResultListenerChooseMediaFiles(resultListenerRef, fileURLs, displayString, mediaIcon);
+ WKOpenPanelResultListenerChooseMediaFiles(resultListenerRef, fileURLs, displayString.get(), mediaIcon);
return;
}
- WKOpenPanelResultListenerChooseMediaFiles(resultListenerRef, adoptWK(WKArrayCreate(&firstItem, 1)).get(), displayString, mediaIcon);
+ WKOpenPanelResultListenerChooseMediaFiles(resultListenerRef, adoptWK(WKArrayCreate(&firstItem, 1)).get(), displayString.get(), mediaIcon);
return;
}
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
