Title: [246179] trunk/Source/WebInspectorUI
- Revision
- 246179
- Author
- [email protected]
- Date
- 2019-06-06 16:37:12 -0700 (Thu, 06 Jun 2019)
Log Message
Web Inspector: REGRESSION(r245833): Timelines: CPU: _javascript_ label is missing and _javascript_ section of pie chart is black
https://bugs.webkit.org/show_bug.cgi?id=198627
Reviewed by Joseph Pecoraro.
* UserInterface/Views/CPUTimelineView.js:
(WI.CPUTimelineView.displayNameForSampleType):
* UserInterface/Views/CPUTimelineView.css:
(.timeline-view.cpu > .content > .overview .legend > .row > .swatch.sample-type-_javascript_):
(.timeline-view.cpu .circle-chart > svg > path.segment.sample-type-_javascript_): Added.
(.timeline-view.cpu .circle-chart > svg > path.segment.sample-type-script): Deleted.
* UserInterface/Views/CPUUsageCombinedView.css:
(.cpu-usage-combined-view > .graph > .range-chart .sample-type-_javascript_): Added.
(.cpu-usage-combined-view > .graph > .range-chart .sample-type-script): Deleted.
Use the enum string added in r245833 (`sample-type-_javascript_`) instead of what was there
before (`sample-type-script`).
* UserInterface/Views/Variables.css:
(:root):
Rename `--cpu-script-*` to `--cpu-_javascript_-*`.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (246178 => 246179)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-06-06 23:35:12 UTC (rev 246178)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-06-06 23:37:12 UTC (rev 246179)
@@ -1,5 +1,28 @@
2019-06-06 Devin Rousso <[email protected]>
+ Web Inspector: REGRESSION(r245833): Timelines: CPU: _javascript_ label is missing and _javascript_ section of pie chart is black
+ https://bugs.webkit.org/show_bug.cgi?id=198627
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/CPUTimelineView.js:
+ (WI.CPUTimelineView.displayNameForSampleType):
+ * UserInterface/Views/CPUTimelineView.css:
+ (.timeline-view.cpu > .content > .overview .legend > .row > .swatch.sample-type-_javascript_):
+ (.timeline-view.cpu .circle-chart > svg > path.segment.sample-type-_javascript_): Added.
+ (.timeline-view.cpu .circle-chart > svg > path.segment.sample-type-script): Deleted.
+ * UserInterface/Views/CPUUsageCombinedView.css:
+ (.cpu-usage-combined-view > .graph > .range-chart .sample-type-_javascript_): Added.
+ (.cpu-usage-combined-view > .graph > .range-chart .sample-type-script): Deleted.
+ Use the enum string added in r245833 (`sample-type-_javascript_`) instead of what was there
+ before (`sample-type-script`).
+
+ * UserInterface/Views/Variables.css:
+ (:root):
+ Rename `--cpu-script-*` to `--cpu-_javascript_-*`.
+
+2019-06-06 Devin Rousso <[email protected]>
+
Web Inspector: Formatter: pretty-print CSS using a Worker
https://bugs.webkit.org/show_bug.cgi?id=197829
<rdar://problem/36891532>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.css (246178 => 246179)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.css 2019-06-06 23:35:12 UTC (rev 246178)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.css 2019-06-06 23:37:12 UTC (rev 246179)
@@ -150,8 +150,8 @@
}
.timeline-view.cpu > .content > .overview .legend > .row > .swatch.sample-type-_javascript_ {
- border: 1px solid var(--cpu-script-stroke-color);
- background-color: var(--cpu-script-fill-color);
+ border: 1px solid var(--cpu-_javascript_-stroke-color);
+ background-color: var(--cpu-_javascript_-fill-color);
}
.timeline-view.cpu > .content > .overview .legend > .row > .swatch.sample-type-style {
@@ -174,9 +174,9 @@
fill: var(--cpu-idle-fill-color);
}
-.timeline-view.cpu .circle-chart > svg > path.segment.sample-type-script {
- stroke: var(--cpu-script-stroke-color);
- fill: var(--cpu-script-fill-color);
+.timeline-view.cpu .circle-chart > svg > path.segment.sample-type-_javascript_ {
+ stroke: var(--cpu-_javascript_-stroke-color);
+ fill: var(--cpu-_javascript_-fill-color);
}
.timeline-view.cpu .circle-chart > svg > path.segment.sample-type-style {
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js (246178 => 246179)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js 2019-06-06 23:35:12 UTC (rev 246178)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js 2019-06-06 23:37:12 UTC (rev 246179)
@@ -54,7 +54,7 @@
static displayNameForSampleType(type)
{
switch (type) {
- case CPUTimelineView.SampleType.Script:
+ case CPUTimelineView.SampleType._javascript_:
return WI.UIString("_javascript_");
case CPUTimelineView.SampleType.Layout:
return WI.repeatedUIString.timelineRecordLayout();
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CPUUsageCombinedView.css (246178 => 246179)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CPUUsageCombinedView.css 2019-06-06 23:35:12 UTC (rev 246178)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CPUUsageCombinedView.css 2019-06-06 23:37:12 UTC (rev 246179)
@@ -127,9 +127,9 @@
stroke-opacity: 0.25;
}
-.cpu-usage-combined-view > .graph > .range-chart .sample-type-script {
- stroke: var(--cpu-script-stroke-color);
- fill: var(--cpu-script-fill-color);
+.cpu-usage-combined-view > .graph > .range-chart .sample-type-_javascript_ {
+ stroke: var(--cpu-_javascript_-stroke-color);
+ fill: var(--cpu-_javascript_-fill-color);
}
.cpu-usage-combined-view > .graph > .range-chart .sample-type-style {
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css (246178 => 246179)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css 2019-06-06 23:35:12 UTC (rev 246178)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css 2019-06-06 23:37:12 UTC (rev 246179)
@@ -140,8 +140,8 @@
--cpu-worker-thread-stroke-color: hsl(59, 79%, 37%);
--cpu-overlay-color: var(--cpu-main-thread-stroke-color);
- --cpu-script-fill-color: hsl(269, 65%, 75%);
- --cpu-script-stroke-color: hsl(269, 33%, 50%);
+ --cpu-_javascript_-fill-color: hsl(269, 65%, 75%);
+ --cpu-_javascript_-stroke-color: hsl(269, 33%, 50%);
--cpu-style-fill-color: hsl(22, 60%, 70%);
--cpu-style-stroke-color: hsl(22, 40%, 50%);
--cpu-layout-fill-color: hsl(0, 65%, 75%);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
