Diff
Modified: trunk/LayoutTests/ChangeLog (246182 => 246183)
--- trunk/LayoutTests/ChangeLog 2019-06-07 00:23:12 UTC (rev 246182)
+++ trunk/LayoutTests/ChangeLog 2019-06-07 00:30:09 UTC (rev 246183)
@@ -1,3 +1,17 @@
+2019-06-06 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r246165.
+ https://bugs.webkit.org/show_bug.cgi?id=198636
+
+ Causing test failures in 7 content-observation tests.
+ (Requested by ShawnRoberts on #webkit).
+
+ Reverted changeset:
+
+ "Restrict fast clicks everywhere to desktop content mode"
+ https://bugs.webkit.org/show_bug.cgi?id=198610
+ https://trac.webkit.org/changeset/246165
+
2019-06-06 Devin Rousso <[email protected]>
Web Inspector: Formatter: pretty-print CSS using a Worker
Deleted: trunk/LayoutTests/fast/events/ios/ipad/fast-click-always-mobile-content-mode-expected.txt (246182 => 246183)
--- trunk/LayoutTests/fast/events/ios/ipad/fast-click-always-mobile-content-mode-expected.txt 2019-06-07 00:23:12 UTC (rev 246182)
+++ trunk/LayoutTests/fast/events/ios/ipad/fast-click-always-mobile-content-mode-expected.txt 2019-06-07 00:30:09 UTC (rev 246183)
@@ -1,2 +0,0 @@
-PASS: Double tap caused zoom.
-This document doesn't have fast clicks because it sets a viewport width. It has a significant zoom since the viewport width is significantly bigger than the body width. However, although fast click everywhere is set to false, the content mode is also set to mobile which disables fast click everywhere, so double tapping on the rectangle above should zoom.
Deleted: trunk/LayoutTests/fast/events/ios/ipad/fast-click-always-mobile-content-mode.html (246182 => 246183)
--- trunk/LayoutTests/fast/events/ios/ipad/fast-click-always-mobile-content-mode.html 2019-06-07 00:23:12 UTC (rev 246182)
+++ trunk/LayoutTests/fast/events/ios/ipad/fast-click-always-mobile-content-mode.html 2019-06-07 00:30:09 UTC (rev 246183)
@@ -1,59 +0,0 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true contentMode=mobile internal:FastClicksEverywhere=true ] -->
-
-<html>
-<meta name="viewport" content="width=800">
-<head>
- <style>
- body {
- font-family: system-ui;
- line-height: 1.4;
- padding: 10px 10px;
- width: 500px;
- margin: 0;
- }
- </style>
- <script src=""
- <script>
- if (window.testRunner) {
- testRunner.dumpAsText();
- testRunner.waitUntilDone();
- }
-
- async function runTest()
- {
- document.getElementById("target").addEventListener("click", handleClick, false);
-
- if (!window.testRunner)
- return;
-
- await UIHelper.humanSpeedZoomByDoubleTappingAt(30, 30);
- document.getElementById("target").textContent = "PASS: Double tap caused zoom.";
- testRunner.notifyDone();
- }
-
- function handleClick(event)
- {
- document.getElementById("target").textContent = "FAIL: Click fired on element with handler.";
- testRunner.notifyDone();
- }
- </script>
- <style>
- body {
- margin: 0;
- }
- #target {
- height: 100px;
- width: 100px;
- background-color: silver;
- }
- </style>
-</head>
-<body _onload_="runTest()">
-<div id="target"></div>
-<div id="description">This document doesn't have fast clicks because
- it sets a viewport width. It has a significant zoom since the viewport
- width is significantly bigger than the body width. However, although fast click
- everywhere is set to false, the content mode is also set to mobile which disables
- fast click everywhere, so double tapping on the rectangle above should zoom.</div>
-</body>
-</html>
Modified: trunk/Source/WebKit/ChangeLog (246182 => 246183)
--- trunk/Source/WebKit/ChangeLog 2019-06-07 00:23:12 UTC (rev 246182)
+++ trunk/Source/WebKit/ChangeLog 2019-06-07 00:30:09 UTC (rev 246183)
@@ -1,5 +1,19 @@
2019-06-06 Commit Queue <[email protected]>
+ Unreviewed, rolling out r246165.
+ https://bugs.webkit.org/show_bug.cgi?id=198636
+
+ Causing test failures in 7 content-observation tests.
+ (Requested by ShawnRoberts on #webkit).
+
+ Reverted changeset:
+
+ "Restrict fast clicks everywhere to desktop content mode"
+ https://bugs.webkit.org/show_bug.cgi?id=198610
+ https://trac.webkit.org/changeset/246165
+
+2019-06-06 Commit Queue <[email protected]>
+
Unreviewed, rolling out r246123.
https://bugs.webkit.org/show_bug.cgi?id=198634
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.h (246182 => 246183)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.h 2019-06-07 00:23:12 UTC (rev 246182)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.h 2019-06-07 00:30:09 UTC (rev 246183)
@@ -518,8 +518,6 @@
bool hasCommittedAnyProvisionalLoads() const { return m_hasCommittedAnyProvisionalLoads; }
- bool allowsFastClicksEverywhere() const { return m_allowsFastClicksEverywhere; }
-
void setIsUsingHighPerformanceWebGL(bool value) { m_isUsingHighPerformanceWebGL = value; }
bool isUsingHighPerformanceWebGL() const { return m_isUsingHighPerformanceWebGL; }
@@ -2480,7 +2478,6 @@
bool m_isUsingHighPerformanceWebGL { false };
bool m_openedByDOM { false };
bool m_hasCommittedAnyProvisionalLoads { false };
- bool m_allowsFastClicksEverywhere { false };
HashMap<String, Ref<WebURLSchemeHandler>> m_urlSchemeHandlersByScheme;
HashMap<uint64_t, Ref<WebURLSchemeHandler>> m_urlSchemeHandlersByIdentifier;
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (246182 => 246183)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2019-06-07 00:23:12 UTC (rev 246182)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2019-06-07 00:30:09 UTC (rev 246183)
@@ -1587,7 +1587,7 @@
if (!_potentialTapInProgress)
return;
- if (_page->preferences().fastClicksEverywhere() && _page->allowsFastClicksEverywhere()) {
+ if (_page->preferences().fastClicksEverywhere()) {
RELEASE_LOG(ViewGestures, "Potential tap found an element and fast taps are forced on. Trigger click. (%p)", self);
[self _setDoubleTapGesturesEnabled:NO];
return;
Modified: trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm (246182 => 246183)
--- trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm 2019-06-07 00:23:12 UTC (rev 246182)
+++ trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm 2019-06-07 00:30:09 UTC (rev 246183)
@@ -1376,8 +1376,6 @@
break;
}
- m_allowsFastClicksEverywhere = false;
-
if (!useDesktopBrowsingMode)
return WebContentMode::Mobile;
@@ -1399,7 +1397,6 @@
policies.setMediaSourcePolicy(WebsiteMediaSourcePolicy::Enable);
policies.setSimulatedMouseEventsDispatchPolicy(WebsiteSimulatedMouseEventsDispatchPolicy::Allow);
policies.setLegacyOverflowScrollingTouchPolicy(WebsiteLegacyOverflowScrollingTouchPolicy::Disable);
- m_allowsFastClicksEverywhere = true;
}
return WebContentMode::Desktop;
