Title: [246192] trunk/Source/WebCore
- Revision
- 246192
- Author
- [email protected]
- Date
- 2019-06-07 01:14:03 -0700 (Fri, 07 Jun 2019)
Log Message
[GStreamer] videorate issues with v4l2src
https://bugs.webkit.org/show_bug.cgi?id=198614
Reviewed by Xabier Rodriguez-Calvar.
Configure videorate to cope with the live stream provided by the
source element. Not doing so might lead to errors in the v4l2
buffer allocator.
* platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:
(WebCore::GStreamerVideoCapturer::createConverter):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (246191 => 246192)
--- trunk/Source/WebCore/ChangeLog 2019-06-07 06:26:25 UTC (rev 246191)
+++ trunk/Source/WebCore/ChangeLog 2019-06-07 08:14:03 UTC (rev 246192)
@@ -1,3 +1,17 @@
+2019-06-07 Philippe Normand <[email protected]>
+
+ [GStreamer] videorate issues with v4l2src
+ https://bugs.webkit.org/show_bug.cgi?id=198614
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ Configure videorate to cope with the live stream provided by the
+ source element. Not doing so might lead to errors in the v4l2
+ buffer allocator.
+
+ * platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:
+ (WebCore::GStreamerVideoCapturer::createConverter):
+
2019-06-06 Andy Estes <[email protected]>
process-swap-on-navigation error when loading blocked website on iOS 12.2 only.
Modified: trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp (246191 => 246192)
--- trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp 2019-06-07 06:26:25 UTC (rev 246191)
+++ trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp 2019-06-07 08:14:03 UTC (rev 246192)
@@ -38,8 +38,8 @@
GstElement* GStreamerVideoCapturer::createConverter()
{
- auto converter = gst_parse_bin_from_description("videoscale ! videoconvert ! videorate", TRUE, nullptr);
-
+ // https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/97#note_56575
+ auto converter = gst_parse_bin_from_description("videoscale ! videoconvert ! videorate drop-_only_=1 average-period=1", TRUE, nullptr);
ASSERT(converter);
return converter;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
