Title: [246227] trunk/LayoutTests
- Revision
- 246227
- Author
- you...@apple.com
- Date
- 2019-06-07 18:30:46 -0700 (Fri, 07 Jun 2019)
Log Message
[ Mac Debug ] REGRESSION (r242975) Layout Test storage/indexeddb/modern/deletedatabase-2-private.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=196445
<rdar://problem/49483061>
Reviewed by Brady Eidson.
Unflake the test by making sure to wait for the onerror event before continuing the test.
* platform/mac-wk2/TestExpectations:
* storage/indexeddb/modern/resources/deletedatabase-2.js:
(prepareDatabase.event.target.onerror):
(continueTest1.request.onsuccess): Deleted.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (246226 => 246227)
--- trunk/LayoutTests/ChangeLog 2019-06-08 00:48:42 UTC (rev 246226)
+++ trunk/LayoutTests/ChangeLog 2019-06-08 01:30:46 UTC (rev 246227)
@@ -1,3 +1,18 @@
+2019-06-07 Youenn Fablet <you...@apple.com>
+
+ [ Mac Debug ] REGRESSION (r242975) Layout Test storage/indexeddb/modern/deletedatabase-2-private.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=196445
+ <rdar://problem/49483061>
+
+ Reviewed by Brady Eidson.
+
+ Unflake the test by making sure to wait for the onerror event before continuing the test.
+
+ * platform/mac-wk2/TestExpectations:
+ * storage/indexeddb/modern/resources/deletedatabase-2.js:
+ (prepareDatabase.event.target.onerror):
+ (continueTest1.request.onsuccess): Deleted.
+
2019-06-07 Truitt Savell <tsav...@apple.com>
Unreviewed, rolling out r246138.
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (246226 => 246227)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2019-06-08 00:48:42 UTC (rev 246226)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2019-06-08 01:30:46 UTC (rev 246227)
@@ -950,8 +950,6 @@
webkit.org/b/189672 [ Mojave Debug ] webgl/2.0.0/conformance2/textures/misc/tex-new-formats.html [ Skip ]
-webkit.org/b/196445 [ Debug ] storage/indexeddb/modern/deletedatabase-2-private.html [ Pass Failure ]
-
webkit.org/b/198195 [ Release ] fast/css/sticky/sticky-left-percentage.html [ Pass ImageOnlyFailure ]
webkit.org/b/187828 [ Release ] fast/css-grid-layout/flex-content-sized-columns-resize.html [ Pass ImageOnlyFailure ]
Modified: trunk/LayoutTests/storage/indexeddb/modern/resources/deletedatabase-2.js (246226 => 246227)
--- trunk/LayoutTests/storage/indexeddb/modern/resources/deletedatabase-2.js 2019-06-08 00:48:42 UTC (rev 246226)
+++ trunk/LayoutTests/storage/indexeddb/modern/resources/deletedatabase-2.js 2019-06-08 01:30:46 UTC (rev 246227)
@@ -21,6 +21,9 @@
}
var dbname;
+var resolveTransactionPromise;
+var transactionPromise = new Promise(resolve => resolveTransactionPromise = resolve);
+
function prepareDatabase(e)
{
debug("Initial upgrade old version - " + e.oldVersion + " new version - " + e.newVersion);
@@ -27,6 +30,7 @@
event.target._onerror_ = function(e) {
debug("Open request error: " + event.target.error.name);
+ resolveTransactionPromise();
}
var versionTransaction = event.target.transaction;
@@ -76,8 +80,9 @@
{
debug("Requesting deleteDatabase");
var request = window.indexedDB.deleteDatabase(dbname);
- request._onsuccess_ = function(e)
+ request._onsuccess_ = async function(e)
{
+ await transactionPromise;
debug("Delete database success: oldVersion " + e.oldVersion + ", newVersion " + e.newVersion);
continueTest2();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
