Title: [246244] tags/Safari-608.1.28.1/Source/WebCore
- Revision
- 246244
- Author
- [email protected]
- Date
- 2019-06-09 14:15:54 -0700 (Sun, 09 Jun 2019)
Log Message
Cherry-pick r246099. rdar://problem/48006291
iPadOS: Google calendars new event picker moves and flickers in landscape with software keyboard
https://bugs.webkit.org/show_bug.cgi?id=198556
Reviewed by Wenson Hsieh.
Fix the issuse that it's really hard to create a new event using Google calendar on iPadOS with
a software keyboard enabled because tapping on date brings up software keyboard and erratically
shifts up/down the new event dialog/pane.
Add a site specific quirk to pretend these input elements have inputmode=none for now.
No new tests since this is a site specific quirk.
* page/Quirks.cpp:
(WebCore::Quirks::needsInputModeNoneImplicitly const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@246099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: tags/Safari-608.1.28.1/Source/WebCore/ChangeLog (246243 => 246244)
--- tags/Safari-608.1.28.1/Source/WebCore/ChangeLog 2019-06-09 21:15:50 UTC (rev 246243)
+++ tags/Safari-608.1.28.1/Source/WebCore/ChangeLog 2019-06-09 21:15:54 UTC (rev 246244)
@@ -1,5 +1,46 @@
2019-06-09 Babak Shafiei <[email protected]>
+ Cherry-pick r246099. rdar://problem/48006291
+
+ iPadOS: Google calendars new event picker moves and flickers in landscape with software keyboard
+ https://bugs.webkit.org/show_bug.cgi?id=198556
+
+ Reviewed by Wenson Hsieh.
+
+ Fix the issuse that it's really hard to create a new event using Google calendar on iPadOS with
+ a software keyboard enabled because tapping on date brings up software keyboard and erratically
+ shifts up/down the new event dialog/pane.
+
+ Add a site specific quirk to pretend these input elements have inputmode=none for now.
+
+ No new tests since this is a site specific quirk.
+
+ * page/Quirks.cpp:
+ (WebCore::Quirks::needsInputModeNoneImplicitly const):
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@246099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-06-04 Ryosuke Niwa <[email protected]>
+
+ iPadOS: Google calendars new event picker moves and flickers in landscape with software keyboard
+ https://bugs.webkit.org/show_bug.cgi?id=198556
+
+ Reviewed by Wenson Hsieh.
+
+ Fix the issuse that it's really hard to create a new event using Google calendar on iPadOS with
+ a software keyboard enabled because tapping on date brings up software keyboard and erratically
+ shifts up/down the new event dialog/pane.
+
+ Add a site specific quirk to pretend these input elements have inputmode=none for now.
+
+ No new tests since this is a site specific quirk.
+
+ * page/Quirks.cpp:
+ (WebCore::Quirks::needsInputModeNoneImplicitly const):
+
+2019-06-09 Babak Shafiei <[email protected]>
+
Cherry-pick r246096. rdar://problem/51375055
[ContentChangeObserver] Gmail text editing controls require two taps
Modified: tags/Safari-608.1.28.1/Source/WebCore/page/Quirks.cpp (246243 => 246244)
--- tags/Safari-608.1.28.1/Source/WebCore/page/Quirks.cpp 2019-06-09 21:15:50 UTC (rev 246243)
+++ tags/Safari-608.1.28.1/Source/WebCore/page/Quirks.cpp 2019-06-09 21:15:54 UTC (rev 246244)
@@ -338,6 +338,17 @@
if (!needsQuirks())
return false;
+ if (element.hasTagName(HTMLNames::inputTag)) {
+ if (!equalLettersIgnoringASCIICase(m_document->url().host(), "calendar.google.com"))
+ return false;
+ static NeverDestroyed<QualifiedName> dataInitialValueAttr(nullAtom(), "data-initial-value", nullAtom());
+ static NeverDestroyed<QualifiedName> dataPreviousValueAttr(nullAtom(), "data-previous-value", nullAtom());
+
+ return equalLettersIgnoringASCIICase(element.attributeWithoutSynchronization(HTMLNames::autocompleteAttr), "off")
+ && element.hasAttributeWithoutSynchronization(dataInitialValueAttr)
+ && element.hasAttributeWithoutSynchronization(dataPreviousValueAttr);
+ }
+
if (!element.hasTagName(HTMLNames::textareaTag))
return false;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
