Title: [246269] trunk/Tools
- Revision
- 246269
- Author
- [email protected]
- Date
- 2019-06-10 11:01:05 -0700 (Mon, 10 Jun 2019)
Log Message
webkitpy: xcrun simctl spawn *** launchctl print system output is not utf-8
https://bugs.webkit.org/show_bug.cgi?id=198723
Reviewed by Aakash Jain.
* Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDevice.is_usable): Do not decode 'print system' output, it's already ASCII.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (246268 => 246269)
--- trunk/Tools/ChangeLog 2019-06-10 17:59:28 UTC (rev 246268)
+++ trunk/Tools/ChangeLog 2019-06-10 18:01:05 UTC (rev 246269)
@@ -1,3 +1,13 @@
+2019-06-10 Jonathan Bedard <[email protected]>
+
+ webkitpy: xcrun simctl spawn *** launchctl print system output is not utf-8
+ https://bugs.webkit.org/show_bug.cgi?id=198723
+
+ Reviewed by Aakash Jain.
+
+ * Scripts/webkitpy/xcode/simulated_device.py:
+ (SimulatedDevice.is_usable): Do not decode 'print system' output, it's already ASCII.
+
2019-06-10 Sihui Liu <[email protected]>
[WKHTTPCookieStore getAllCookies:] may return duplicate cookies
Modified: trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py (246268 => 246269)
--- trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py 2019-06-10 17:59:28 UTC (rev 246268)
+++ trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py 2019-06-10 18:01:05 UTC (rev 246269)
@@ -534,7 +534,7 @@
_log.debug('{} has no service to check if the device is usable'.format(self.device_type.software_variant))
return True
- for line in self.executive.run_command([SimulatedDeviceManager.xcrun, 'simctl', 'spawn', self.udid, 'launchctl', 'print', 'system']).splitlines():
+ for line in self.executive.run_command([SimulatedDeviceManager.xcrun, 'simctl', 'spawn', self.udid, 'launchctl', 'print', 'system'], decode_output=False).splitlines():
if home_screen_service in line:
return True
return False
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
