Diff
Modified: trunk/Tools/ChangeLog (246281 => 246282)
--- trunk/Tools/ChangeLog 2019-06-10 21:29:57 UTC (rev 246281)
+++ trunk/Tools/ChangeLog 2019-06-10 21:35:13 UTC (rev 246282)
@@ -1,3 +1,24 @@
+2019-06-10 Alexey Proskuryakov <[email protected]>
+
+ Tool binaries like WebKitTestRunner have too aggressive stripping, resulting in non-symbolicated crash logs
+ https://bugs.webkit.org/show_bug.cgi?id=198616
+ rdar://problem/36386573
+
+ Reviewed by David Kilzer.
+
+ Adding an explicit STRIP_STYLE to appropriate xcconfigs.
+
+ * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
+ * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
+ * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
+ * ImageDiff/cg/Configurations/ImageDiff.xcconfig:
+ * MiniBrowser/Configurations/MiniBrowser.xcconfig:
+ * MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig:
+ * TestWebKitAPI/Configurations/TestWTF.xcconfig:
+ * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
+ * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
+ * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
+
2019-06-10 Wenson Hsieh <[email protected]>
[iOS] fast/xsl tests are flaky when run after certain viewport shrink-to-fit tests
Modified: trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig (246281 => 246282)
--- trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig 2019-06-10 21:29:57 UTC (rev 246281)
+++ trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig 2019-06-10 21:35:13 UTC (rev 246282)
@@ -27,6 +27,7 @@
PLATFORM_OTHER_LDFLAGS[sdk=iphone*] = -framework _javascript_Core;
PLATFORM_OTHER_LDFLAGS[sdk=macosx*] = -lWebCoreTestSupport -force_load $(BUILT_PRODUCTS_DIR)/libDumpRenderTree.a -framework Carbon -framework Cocoa -framework _javascript_Core -framework OpenGL -framework QuartzCore -framework WebKit;
LD_RUNPATH_SEARCH_PATHS = "@loader_path/.";
+STRIP_STYLE = debugging;
PRODUCT_NAME = DumpRenderTree;
SKIP_INSTALL[sdk=macosx*] = NO;
SKIP_INSTALL[sdk=iphone*] = YES;
Modified: trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig (246281 => 246282)
--- trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig 2019-06-10 21:29:57 UTC (rev 246281)
+++ trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig 2019-06-10 21:35:13 UTC (rev 246282)
@@ -31,6 +31,8 @@
PLATFORM_OTHER_LDFLAGS[sdk=iphone*] = -lWebCoreTestSupport -force_load $(BUILT_PRODUCTS_DIR)/libDumpRenderTree.a -framework QuartzCore -framework CFNetwork -framework CoreFoundation -framework CoreGraphics -framework Foundation -framework GraphicsServices -framework ImageIO -framework MobileCoreServices -framework UIKit -framework WebCore -framework _javascript_Core -framework WebKit $(OTHER_LDFLAGS_FONTS);
PLATFORM_OTHER_LDFLAGS[sdk=macosx*] = -framework _javascript_Core;
+STRIP_STYLE = debugging;
+
LD_RUNPATH_SEARCH_PATHS = "@loader_path/.";
EXCLUDED_SOURCE_FILE_NAMES[sdk=macosx*] = ios/*;
Modified: trunk/Tools/DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig (246281 => 246282)
--- trunk/Tools/DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig 2019-06-10 21:29:57 UTC (rev 246281)
+++ trunk/Tools/DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig 2019-06-10 21:35:13 UTC (rev 246282)
@@ -26,3 +26,4 @@
#include "BaseTarget.xcconfig"
OTHER_LDFLAGS[sdk=macosx*] = $(inherited) -framework Carbon -framework Cocoa -framework OpenGL -framework IOKit;
+STRIP_STYLE = debugging;
Modified: trunk/Tools/ImageDiff/cg/Configurations/ImageDiff.xcconfig (246281 => 246282)
--- trunk/Tools/ImageDiff/cg/Configurations/ImageDiff.xcconfig 2019-06-10 21:29:57 UTC (rev 246281)
+++ trunk/Tools/ImageDiff/cg/Configurations/ImageDiff.xcconfig 2019-06-10 21:35:13 UTC (rev 246282)
@@ -28,3 +28,4 @@
PRODUCT_NAME = ImageDiff;
OTHER_LDFLAGS[sdk=macosx*] = $(inherited) -framework Carbon -framework Cocoa -framework QuartzCore;
OTHER_LDFLAGS[sdk=iphone*] = $(inherited) -framework CoreFoundation -framework CoreGraphics -framework MobileCoreServices -framework ImageIO;
+STRIP_STYLE = debugging;
Modified: trunk/Tools/MiniBrowser/Configurations/MiniBrowser.xcconfig (246281 => 246282)
--- trunk/Tools/MiniBrowser/Configurations/MiniBrowser.xcconfig 2019-06-10 21:29:57 UTC (rev 246281)
+++ trunk/Tools/MiniBrowser/Configurations/MiniBrowser.xcconfig 2019-06-10 21:35:13 UTC (rev 246282)
@@ -28,3 +28,4 @@
INFOPLIST_FILE = mac/Info.plist
EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*] = *
OTHER_LDFLAGS[sdk=macosx*] = $(inherited) -framework Cocoa -framework WebKit
+STRIP_STYLE = debugging;
Modified: trunk/Tools/MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig (246281 => 246282)
--- trunk/Tools/MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig 2019-06-10 21:29:57 UTC (rev 246281)
+++ trunk/Tools/MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig 2019-06-10 21:35:13 UTC (rev 246282)
@@ -22,3 +22,5 @@
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
PRODUCT_NAME = MiniBrowser
+
+STRIP_STYLE=debugging
Modified: trunk/Tools/TestWebKitAPI/Configurations/TestWTF.xcconfig (246281 => 246282)
--- trunk/Tools/TestWebKitAPI/Configurations/TestWTF.xcconfig 2019-06-10 21:29:57 UTC (rev 246281)
+++ trunk/Tools/TestWebKitAPI/Configurations/TestWTF.xcconfig 2019-06-10 21:35:13 UTC (rev 246282)
@@ -36,3 +36,5 @@
// FIXME: This should not be built on iOS. Instead we should create and use a TestWTF application.
OTHER_LDFLAGS_PLATFORM[sdk=iphone*] = -framework CoreGraphics;
+
+STRIP_STYLE = debugging;
Modified: trunk/Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig (246281 => 246282)
--- trunk/Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig 2019-06-10 21:29:57 UTC (rev 246281)
+++ trunk/Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig 2019-06-10 21:35:13 UTC (rev 246282)
@@ -37,3 +37,5 @@
LD_RUNPATH_SEARCH_PATHS = "@loader_path";
CODE_SIGN_ENTITLEMENTS[sdk=iphone*] = Configurations/TestWebKitAPI-iOS.entitlements;
+
+STRIP_STYLE = debugging;
Modified: trunk/Tools/WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig (246281 => 246282)
--- trunk/Tools/WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig 2019-06-10 21:29:57 UTC (rev 246281)
+++ trunk/Tools/WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig 2019-06-10 21:35:13 UTC (rev 246282)
@@ -30,6 +30,7 @@
PRODUCT_NAME = WebKitTestRunner;
GCC_ENABLE_OBJC_EXCEPTIONS = YES;
OTHER_LDFLAGS[sdk=macosx*] = $(inherited) -lWebKitTestRunner -framework Carbon -framework Cocoa -framework _javascript_Core -framework WebKit;
+STRIP_STYLE = debugging;
SKIP_INSTALL[sdk=iphone*] = YES;
EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*] = mac/*;
INCLUDED_SOURCE_FILE_NAMES[sdk=iphone*] = mac/main.mm;
Modified: trunk/Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig (246281 => 246282)
--- trunk/Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig 2019-06-10 21:29:57 UTC (rev 246281)
+++ trunk/Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig 2019-06-10 21:35:13 UTC (rev 246282)
@@ -32,6 +32,8 @@
OTHER_LDFLAGS = $(inherited) -lWebKitTestRunner -lWebCoreTestSupport -framework _javascript_Core -framework CoreGraphics -framework QuartzCore -framework ImageIO -framework IOKit -framework UIKit -framework WebKit -framework Foundation -framework GraphicsServices;
+STRIP_STYLE = debugging;
+
SKIP_INSTALL[sdk=macosx*] = YES;
EXCLUDED_SOURCE_FILE_NAMES[sdk=macosx*] = ios/* AppDelegate.m;
