Title: [246299] trunk/Source/_javascript_Core
- Revision
- 246299
- Author
- [email protected]
- Date
- 2019-06-10 17:38:48 -0700 (Mon, 10 Jun 2019)
Log Message
[WinCairo] Remove build warning from RemoteInspector.
https://bugs.webkit.org/show_bug.cgi?id=198724
Reviewed by Joseph Pecoraro.
In `RemoteInspectorConnectionClient.h`, an interface was defined with empty implementation.
This method is to be overwritten by sub classes so that parameter name is important
so they are commented out rather than just removing from the definition.
* inspector/remote/RemoteInspector.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (246298 => 246299)
--- trunk/Source/_javascript_Core/ChangeLog 2019-06-10 23:53:50 UTC (rev 246298)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-06-11 00:38:48 UTC (rev 246299)
@@ -1,3 +1,16 @@
+2019-06-10 Basuke Suzuki <[email protected]>
+
+ [WinCairo] Remove build warning from RemoteInspector.
+ https://bugs.webkit.org/show_bug.cgi?id=198724
+
+ Reviewed by Joseph Pecoraro.
+
+ In `RemoteInspectorConnectionClient.h`, an interface was defined with empty implementation.
+ This method is to be overwritten by sub classes so that parameter name is important
+ so they are commented out rather than just removing from the definition.
+
+ * inspector/remote/RemoteInspector.h:
+
2019-06-10 Sam Weinig <[email protected]>
Remove Dashboard support
Modified: trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorConnectionClient.h (246298 => 246299)
--- trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorConnectionClient.h 2019-06-10 23:53:50 UTC (rev 246298)
+++ trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorConnectionClient.h 2019-06-11 00:38:48 UTC (rev 246299)
@@ -37,7 +37,7 @@
class RemoteInspectorConnectionClient : public CanMakeWeakPtr<RemoteInspectorConnectionClient> {
public:
void didReceiveWebInspectorEvent(ConnectionID, Vector<uint8_t>&&);
- virtual void didAccept(ConnectionID acceptedID, ConnectionID listenerID, Socket::Domain) { }
+ virtual void didAccept(ConnectionID /* acceptedID */, ConnectionID /* listenerID */, Socket::Domain) { }
virtual void didClose(ConnectionID) = 0;
struct Event {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
