Title: [246328] trunk/Source
- Revision
- 246328
- Author
- [email protected]
- Date
- 2019-06-11 12:33:57 -0700 (Tue, 11 Jun 2019)
Log Message
Unreviewed build warning fixes
Source/_javascript_Core:
Silence -Wreturn-type warning
* wasm/WasmTable.cpp:
(JSC::Wasm::Table::tryCreate):
Source/WebCore:
Silence -Wunused-parameter warning
* testing/Internals.cpp:
(WebCore::Internals::storeRegistrationsOnDisk):
Source/WebKit:
Silence -Wunused-variable warning
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::clearWebProcessIsPlayingAudibleMedia):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (246327 => 246328)
--- trunk/Source/_javascript_Core/ChangeLog 2019-06-11 19:02:31 UTC (rev 246327)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-06-11 19:33:57 UTC (rev 246328)
@@ -1,3 +1,12 @@
+2019-06-11 Michael Catanzaro <[email protected]>
+
+ Unreviewed build warning fixes
+
+ Silence -Wreturn-type warning
+
+ * wasm/WasmTable.cpp:
+ (JSC::Wasm::Table::tryCreate):
+
2019-06-11 Saam Barati <[email protected]>
Roll out PAC cage
Modified: trunk/Source/_javascript_Core/wasm/WasmTable.cpp (246327 => 246328)
--- trunk/Source/_javascript_Core/wasm/WasmTable.cpp 2019-06-11 19:02:31 UTC (rev 246327)
+++ trunk/Source/_javascript_Core/wasm/WasmTable.cpp 2019-06-11 19:33:57 UTC (rev 246328)
@@ -76,6 +76,8 @@
case TableElementType::Anyref:
return adoptRef(new Table(initial, maximum));
}
+
+ RELEASE_ASSERT_NOT_REACHED();
}
Optional<uint32_t> Table::grow(uint32_t delta)
Modified: trunk/Source/WebCore/ChangeLog (246327 => 246328)
--- trunk/Source/WebCore/ChangeLog 2019-06-11 19:02:31 UTC (rev 246327)
+++ trunk/Source/WebCore/ChangeLog 2019-06-11 19:33:57 UTC (rev 246328)
@@ -1,3 +1,12 @@
+2019-06-11 Michael Catanzaro <[email protected]>
+
+ Unreviewed build warning fixes
+
+ Silence -Wunused-parameter warning
+
+ * testing/Internals.cpp:
+ (WebCore::Internals::storeRegistrationsOnDisk):
+
2019-06-10 Simon Fraser <[email protected]>
Add logging for UI-side compositing hit-testing
Modified: trunk/Source/WebCore/testing/Internals.cpp (246327 => 246328)
--- trunk/Source/WebCore/testing/Internals.cpp 2019-06-11 19:02:31 UTC (rev 246327)
+++ trunk/Source/WebCore/testing/Internals.cpp 2019-06-11 19:33:57 UTC (rev 246328)
@@ -4806,6 +4806,8 @@
connection.storeRegistrationsOnDiskForTesting([promise = WTFMove(promise)]() mutable {
promise.resolve();
});
+#else
+ promise.resolve();
#endif
}
Modified: trunk/Source/WebKit/ChangeLog (246327 => 246328)
--- trunk/Source/WebKit/ChangeLog 2019-06-11 19:02:31 UTC (rev 246327)
+++ trunk/Source/WebKit/ChangeLog 2019-06-11 19:33:57 UTC (rev 246328)
@@ -1,3 +1,12 @@
+2019-06-11 Michael Catanzaro <[email protected]>
+
+ Unreviewed build warning fixes
+
+ Silence -Wunused-variable warning
+
+ * UIProcess/WebProcessPool.cpp:
+ (WebKit::WebProcessPool::clearWebProcessIsPlayingAudibleMedia):
+
2019-06-10 Simon Fraser <[email protected]>
Add logging for UI-side compositing hit-testing
Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.cpp (246327 => 246328)
--- trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2019-06-11 19:02:31 UTC (rev 246327)
+++ trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2019-06-11 19:33:57 UTC (rev 246328)
@@ -2597,7 +2597,8 @@
ASSERT_UNUSED(result, result);
auto* process = WebProcessProxy::processForIdentifier(processID);
- ASSERT(process);
+ ASSERT_UNUSED(process, process);
+
RELEASE_LOG(ProcessSuspension, "Web process pid %u is no longer playing audible media", (unsigned)process->processIdentifier());
if (m_processesPlayingAudibleMedia.isEmpty()) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
