Title: [246338] trunk/LayoutTests
- Revision
- 246338
- Author
- [email protected]
- Date
- 2019-06-11 16:00:58 -0700 (Tue, 11 Jun 2019)
Log Message
[iOS] Adjust test fast/events/ios/keyup.html to ignore Shift keyups
https://bugs.webkit.org/show_bug.cgi?id=198768
<rdar://problem/46082743>
Reviewed by Brent Fulgham.
Ignore Shift keyups as in the future they will be emitted. We have existing test coverage for them
currently skipped in OpenSource that will be unskipped in the future once we enable ENABLE(FULL_KEYBOARD_ACCESS).
* fast/events/ios/keyup.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (246337 => 246338)
--- trunk/LayoutTests/ChangeLog 2019-06-11 22:39:36 UTC (rev 246337)
+++ trunk/LayoutTests/ChangeLog 2019-06-11 23:00:58 UTC (rev 246338)
@@ -1,5 +1,18 @@
2019-06-11 Daniel Bates <[email protected]>
+ [iOS] Adjust test fast/events/ios/keyup.html to ignore Shift keyups
+ https://bugs.webkit.org/show_bug.cgi?id=198768
+ <rdar://problem/46082743>
+
+ Reviewed by Brent Fulgham.
+
+ Ignore Shift keyups as in the future they will be emitted. We have existing test coverage for them
+ currently skipped in OpenSource that will be unskipped in the future once we enable ENABLE(FULL_KEYBOARD_ACCESS).
+
+ * fast/events/ios/keyup.html:
+
+2019-06-11 Daniel Bates <[email protected]>
+
Fix up test result following r245161.
<rdar://problem/51032967>
Modified: trunk/LayoutTests/fast/events/ios/keyup.html (246337 => 246338)
--- trunk/LayoutTests/fast/events/ios/keyup.html 2019-06-11 22:39:36 UTC (rev 246337)
+++ trunk/LayoutTests/fast/events/ios/keyup.html 2019-06-11 23:00:58 UTC (rev 246338)
@@ -26,10 +26,15 @@
function logKeyEvent(event)
{
- let pieces = [];
- for (let propertyName of ["type", "key", "code", "keyIdentifier", "keyCode", "charCode", "keyCode", "which"])
- pieces.push(`${propertyName}: ${event[propertyName]}`);
- log(pieces.join(", "));
+ // Ignore Shift keyups, if they are dispatched, as not all versions of iOS dispatch them.
+ if (event.key == "Shift")
+ ++numberOfFiredKeyEventsForTestComplete;
+ if (event.key !== "Shift") {
+ let pieces = [];
+ for (let propertyName of ["type", "key", "code", "keyIdentifier", "keyCode", "charCode", "keyCode", "which"])
+ pieces.push(`${propertyName}: ${event[propertyName]}`);
+ log(pieces.join(", "));
+ }
if (++numberOfFiredKeyEvents >= numberOfFiredKeyEventsForTestComplete && window.testRunner)
testRunner.notifyDone();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
