Modified: trunk/Tools/BuildSlaveSupport/ews-build/loadConfig.py (246372 => 246373)
--- trunk/Tools/BuildSlaveSupport/ews-build/loadConfig.py 2019-06-12 20:31:11 UTC (rev 246372)
+++ trunk/Tools/BuildSlaveSupport/ews-build/loadConfig.py 2019-06-12 20:38:18 UTC (rev 246373)
@@ -58,17 +58,17 @@
for builder in config['builders']:
builder['tags'] = getTagsForBuilder(builder)
factory = globals()[builder['factory']]
- builder['description'] = builder.pop("shortname")
+ builder['description'] = builder.pop('shortname')
factorykwargs = {}
- for key in ["platform", "configuration", "architectures", "triggers", "additionalArguments"]:
+ for key in ['platform', 'configuration', 'architectures', 'triggers', 'additionalArguments']:
value = builder.pop(key, None)
if value:
factorykwargs[key] = value
- builder["factory"] = factory(**factorykwargs)
+ builder['factory'] = factory(**factorykwargs)
if use_localhost_worker:
- builder['workernames'].append("local-worker")
+ builder['workernames'].append('local-worker')
c['builders'].append(builder)
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py (246372 => 246373)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2019-06-12 20:31:11 UTC (rev 246372)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2019-06-12 20:38:18 UTC (rev 246373)
@@ -477,7 +477,7 @@
self.setProperty('configuration', 'release')
self.expectRemoteCommands(
ExpectShell(workdir='wkdir',
- command=["perl", "Tools/Scripts/build-webkit", '--release'],
+ command=['perl', 'Tools/Scripts/build-webkit', '--release'],
)
+ 0,
)
@@ -490,7 +490,7 @@
self.setProperty('configuration', 'debug')
self.expectRemoteCommands(
ExpectShell(workdir='wkdir',
- command=["perl", "Tools/Scripts/build-webkit", '--debug'],
+ command=['perl', 'Tools/Scripts/build-webkit', '--debug'],
)
+ ExpectShell.log('stdio', stdout='1 error generated.')
+ 2,
@@ -559,7 +559,7 @@
self.setProperty('configuration', 'release')
self.expectRemoteCommands(
ExpectShell(workdir='wkdir',
- command=["perl", "Tools/Scripts/build-jsc", '--release'],
+ command=['perl', 'Tools/Scripts/build-jsc', '--release'],
)
+ 0,
)
@@ -572,7 +572,7 @@
self.setProperty('configuration', 'debug')
self.expectRemoteCommands(
ExpectShell(workdir='wkdir',
- command=["perl", "Tools/Scripts/build-jsc", '--debug'],
+ command=['perl', 'Tools/Scripts/build-jsc', '--debug'],
)
+ ExpectShell.log('stdio', stdout='1 error generated.')
+ 2,
Modified: trunk/Tools/ChangeLog (246372 => 246373)
--- trunk/Tools/ChangeLog 2019-06-12 20:31:11 UTC (rev 246372)
+++ trunk/Tools/ChangeLog 2019-06-12 20:38:18 UTC (rev 246373)
@@ -1,3 +1,13 @@
+2019-06-12 Aakash Jain <[email protected]>
+
+ Replace double-quotes with single quotes in loadConfig.py
+ https://bugs.webkit.org/show_bug.cgi?id=198792
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-build/loadConfig.py:
+ * BuildSlaveSupport/ews-build/steps_unittest.py:
+
22019-06-11 Brent Fulgham <[email protected]>
Add mechanism and test case to check if ITP is active
