Title: [246448] trunk/Source/WebKit
- Revision
- 246448
- Author
- pecor...@apple.com
- Date
- 2019-06-14 15:52:24 -0700 (Fri, 14 Jun 2019)
Log Message
[Cocoa] NSFileWrapper associated with _WKAttachment
https://bugs.webkit.org/show_bug.cgi?id=198871
<rdar://problem/51760625>
Reviewed by Wenson Hsieh.
* UIProcess/API/Cocoa/_WKAttachment.mm:
(-[_WKAttachment dealloc]):
Ensure we destruct the API::Object associated with this so RetainPtrs can release.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (246447 => 246448)
--- trunk/Source/WebKit/ChangeLog 2019-06-14 22:50:00 UTC (rev 246447)
+++ trunk/Source/WebKit/ChangeLog 2019-06-14 22:52:24 UTC (rev 246448)
@@ -1,3 +1,15 @@
+2019-06-14 Joseph Pecoraro <pecor...@apple.com>
+
+ [Cocoa] NSFileWrapper associated with _WKAttachment
+ https://bugs.webkit.org/show_bug.cgi?id=198871
+ <rdar://problem/51760625>
+
+ Reviewed by Wenson Hsieh.
+
+ * UIProcess/API/Cocoa/_WKAttachment.mm:
+ (-[_WKAttachment dealloc]):
+ Ensure we destruct the API::Object associated with this so RetainPtrs can release.
+
2019-06-14 Tim Horton <timothy_hor...@apple.com>
WebKit's NSAttributedString.h is not included in the WebKit.h umbrella header
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAttachment.mm (246447 => 246448)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAttachment.mm 2019-06-14 22:50:00 UTC (rev 246447)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAttachment.mm 2019-06-14 22:52:24 UTC (rev 246448)
@@ -102,6 +102,13 @@
@implementation _WKAttachment
+- (void)dealloc
+{
+ _attachment->~Attachment();
+
+ [super dealloc];
+}
+
- (API::Object&)_apiObject
{
return *_attachment;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
