Title: [246462] trunk/Source/WebCore
- Revision
- 246462
- Author
- [email protected]
- Date
- 2019-06-15 07:13:55 -0700 (Sat, 15 Jun 2019)
Log Message
[LFC[MarginCollapsing] Anonymous boxes never collapse their margins with siblings.
https://bugs.webkit.org/show_bug.cgi?id=198884
<rdar://problem/51773509>
Reviewed by Antti Koivisto.
* layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithPreviousSiblingMarginAfter):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (246461 => 246462)
--- trunk/Source/WebCore/ChangeLog 2019-06-15 14:11:37 UTC (rev 246461)
+++ trunk/Source/WebCore/ChangeLog 2019-06-15 14:13:55 UTC (rev 246462)
@@ -1,5 +1,16 @@
2019-06-15 Zalan Bujtas <[email protected]>
+ [LFC[MarginCollapsing] Anonymous boxes never collapse their margins with siblings.
+ https://bugs.webkit.org/show_bug.cgi?id=198884
+ <rdar://problem/51773509>
+
+ Reviewed by Antti Koivisto.
+
+ * layout/blockformatting/BlockMarginCollapse.cpp:
+ (WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithPreviousSiblingMarginAfter):
+
+2019-06-15 Zalan Bujtas <[email protected]>
+
[LFC][MarginCollapsing] Add check for computed height value in MarginCollapse::marginsCollapseThrough
https://bugs.webkit.org/show_bug.cgi?id=198883
<rdar://problem/51773395>
Modified: trunk/Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp (246461 => 246462)
--- trunk/Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp 2019-06-15 14:11:37 UTC (rev 246461)
+++ trunk/Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp 2019-06-15 14:13:55 UTC (rev 246462)
@@ -158,6 +158,9 @@
return false;
auto& previousInFlowSibling = *layoutBox.previousInFlowSibling();
+ if (previousInFlowSibling.isAnonymous())
+ return false;
+
// Margins between a floated box and any other box do not collapse.
if (layoutBox.isFloatingPositioned() || previousInFlowSibling.isFloatingPositioned())
return false;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
