Title: [246480] trunk/Source/WebCore
- Revision
- 246480
- Author
- [email protected]
- Date
- 2019-06-16 13:02:17 -0700 (Sun, 16 Jun 2019)
Log Message
[LFC][IFC] Line::isVisuallyEmpty should check inline-block boxes.
https://bugs.webkit.org/show_bug.cgi?id=198894
<rdar://problem/51780886>
Reviewed by Antti Koivisto.
Non-zero width/height inline-block boxes make the line visually non-empty.
* layout/inlineformatting/InlineLine.cpp:
(WebCore::Layout::Line::isVisuallyEmpty const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (246479 => 246480)
--- trunk/Source/WebCore/ChangeLog 2019-06-16 19:33:18 UTC (rev 246479)
+++ trunk/Source/WebCore/ChangeLog 2019-06-16 20:02:17 UTC (rev 246480)
@@ -1,5 +1,18 @@
2019-06-16 Zalan Bujtas <[email protected]>
+ [LFC][IFC] Line::isVisuallyEmpty should check inline-block boxes.
+ https://bugs.webkit.org/show_bug.cgi?id=198894
+ <rdar://problem/51780886>
+
+ Reviewed by Antti Koivisto.
+
+ Non-zero width/height inline-block boxes make the line visually non-empty.
+
+ * layout/inlineformatting/InlineLine.cpp:
+ (WebCore::Layout::Line::isVisuallyEmpty const):
+
+2019-06-16 Zalan Bujtas <[email protected]>
+
[LFC] Add Layout::Box::isContainingBlockDescendantOf
https://bugs.webkit.org/show_bug.cgi?id=198888
<rdar://problem/51776466>
Modified: trunk/Source/WebCore/layout/inlineformatting/InlineLine.cpp (246479 => 246480)
--- trunk/Source/WebCore/layout/inlineformatting/InlineLine.cpp 2019-06-16 19:33:18 UTC (rev 246479)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineLine.cpp 2019-06-16 20:02:17 UTC (rev 246480)
@@ -76,6 +76,15 @@
}
if (run->inlineItem.isContainerEnd())
continue;
+ if (run->inlineItem.layoutBox().establishesFormattingContext()) {
+ ASSERT(run->inlineItem.layoutBox().isInlineBlockBox());
+ auto& displayBox = m_layoutState.displayBoxForLayoutBox(run->inlineItem.layoutBox());
+ if (!displayBox.width())
+ continue;
+ if (m_skipVerticalAligment || displayBox.height())
+ return false;
+ continue;
+ }
if (!run->isCollapsed)
return false;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
