Title: [246521] trunk/Source/WebKit
- Revision
- 246521
- Author
- [email protected]
- Date
- 2019-06-17 16:11:56 -0700 (Mon, 17 Jun 2019)
Log Message
Add null check in WebFrameLoaderClient::assignIdentifierToInitialRequest
https://bugs.webkit.org/show_bug.cgi?id=198926
<rdar://problem/50079713>
Patch by Alex Christensen <[email protected]> on 2019-06-17
Reviewed by Brady Eidson.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::assignIdentifierToInitialRequest):
WebKitLegacy's version already checks null for the corresponding call.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (246520 => 246521)
--- trunk/Source/WebKit/ChangeLog 2019-06-17 23:07:32 UTC (rev 246520)
+++ trunk/Source/WebKit/ChangeLog 2019-06-17 23:11:56 UTC (rev 246521)
@@ -1,5 +1,17 @@
2019-06-17 Alex Christensen <[email protected]>
+ Add null check in WebFrameLoaderClient::assignIdentifierToInitialRequest
+ https://bugs.webkit.org/show_bug.cgi?id=198926
+ <rdar://problem/50079713>
+
+ Reviewed by Brady Eidson.
+
+ * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+ (WebKit::WebFrameLoaderClient::assignIdentifierToInitialRequest):
+ WebKitLegacy's version already checks null for the corresponding call.
+
+2019-06-17 Alex Christensen <[email protected]>
+
Fix internal build after r246514
https://bugs.webkit.org/show_bug.cgi?id=198874
Modified: trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (246520 => 246521)
--- trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2019-06-17 23:07:32 UTC (rev 246520)
+++ trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2019-06-17 23:11:56 UTC (rev 246521)
@@ -197,7 +197,7 @@
return;
bool pageIsProvisionallyLoading = false;
- if (FrameLoader* frameLoader = loader->frameLoader())
+ if (FrameLoader* frameLoader = loader ? loader->frameLoader() : nullptr)
pageIsProvisionallyLoading = frameLoader->provisionalDocumentLoader() == loader;
webPage->injectedBundleResourceLoadClient().didInitiateLoadForResource(*webPage, *m_frame, identifier, request, pageIsProvisionallyLoading);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes