Title: [246532] trunk/Source/WebInspectorUI
Revision
246532
Author
[email protected]
Date
2019-06-17 21:32:41 -0700 (Mon, 17 Jun 2019)

Log Message

Web Inspector: Elements: remove ellipses from "Break on" context menu item title
https://bugs.webkit.org/show_bug.cgi?id=198944

Reviewed by Devin Rousso.

Update context menu title to comply with Apple HI guidelines.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Views/ContextMenuUtilities.js:

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (246531 => 246532)


--- trunk/Source/WebInspectorUI/ChangeLog	2019-06-18 02:33:50 UTC (rev 246531)
+++ trunk/Source/WebInspectorUI/ChangeLog	2019-06-18 04:32:41 UTC (rev 246532)
@@ -1,3 +1,15 @@
+2019-06-17  Matt Baker  <[email protected]>
+
+        Web Inspector: Elements: remove ellipses from "Break on" context menu item title
+        https://bugs.webkit.org/show_bug.cgi?id=198944
+
+        Reviewed by Devin Rousso.
+
+        Update context menu title to comply with Apple HI guidelines.
+
+        * Localizations/en.lproj/localizedStrings.js:
+        * UserInterface/Views/ContextMenuUtilities.js:
+
 2019-06-17  Devin Rousso  <[email protected]>
 
         Web Inspector: Debugger: adding a DOM/Event/URL breakpoint should enable breakpoints

Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (246531 => 246532)


--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2019-06-18 02:33:50 UTC (rev 246531)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2019-06-18 04:32:41 UTC (rev 246532)
@@ -166,9 +166,9 @@
 localizedStrings["Body:"] = "Body:";
 localizedStrings["Boundary"] = "Boundary";
 localizedStrings["Box Model"] = "Box Model";
+localizedStrings["Break on"] = "Break on";
 localizedStrings["Break on events with name:"] = "Break on events with name:";
 localizedStrings["Break on request with URL:"] = "Break on request with URL:";
-localizedStrings["Break on\u2026"] = "Break on\u2026";
 localizedStrings["Breakdown"] = "Breakdown";
 localizedStrings["Breakdown of each memory category at the end of the selected time range"] = "Breakdown of each memory category at the end of the selected time range";
 localizedStrings["Breakdown of time spent on the main thread"] = "Breakdown of time spent on the main thread";

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js (246531 => 246532)


--- trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js	2019-06-18 02:33:50 UTC (rev 246531)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js	2019-06-18 04:32:41 UTC (rev 246532)
@@ -291,7 +291,7 @@
 
     contextMenu.__domBreakpointItemsAdded = true;
 
-    let subMenu = contextMenu.appendSubMenuItem(WI.UIString("Break on\u2026"));
+    let subMenu = contextMenu.appendSubMenuItem(WI.UIString("Break on"));
 
     let breakpoints = WI.domDebuggerManager.domBreakpointsForNode(domNode);
     let keyValuePairs = breakpoints.map((breakpoint) => [breakpoint.type, breakpoint]);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to