Title: [246543] trunk/Source/WebCore
- Revision
- 246543
- Author
- [email protected]
- Date
- 2019-06-18 09:44:36 -0700 (Tue, 18 Jun 2019)
Log Message
Unreviewed, rolling out r246524.
Caused 45 webgpu/ crashes.
Reverted changeset:
"[WHLSL] The name resolver does not deal with
nativeFunctionDeclaration"
https://bugs.webkit.org/show_bug.cgi?id=198306
https://trac.webkit.org/changeset/246524
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (246542 => 246543)
--- trunk/Source/WebCore/ChangeLog 2019-06-18 16:41:40 UTC (rev 246542)
+++ trunk/Source/WebCore/ChangeLog 2019-06-18 16:44:36 UTC (rev 246543)
@@ -1,3 +1,16 @@
+2019-06-18 Truitt Savell <[email protected]>
+
+ Unreviewed, rolling out r246524.
+
+ Caused 45 webgpu/ crashes.
+
+ Reverted changeset:
+
+ "[WHLSL] The name resolver does not deal with
+ nativeFunctionDeclaration"
+ https://bugs.webkit.org/show_bug.cgi?id=198306
+ https://trac.webkit.org/changeset/246524
+
2019-06-18 Zalan Bujtas <[email protected]>
[LFC][IFC] Inline quirks should have their dedicated class.
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameResolver.cpp (246542 => 246543)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameResolver.cpp 2019-06-18 16:41:40 UTC (rev 246542)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameResolver.cpp 2019-06-18 16:44:36 UTC (rev 246543)
@@ -94,16 +94,6 @@
newNameResolver.checkErrorAndVisit(functionDefinition.block());
}
-void NameResolver::visit(AST::NativeFunctionDeclaration& nativeFunctionDeclaration)
-{
- NameContext newNameContext(&m_nameContext);
- NameResolver newNameResolver(newNameContext);
- newNameResolver.setCurrentFunctionDefinition(m_currentFunction);
- checkErrorAndVisit(nativeFunctionDeclaration.type());
- for (auto& parameter : nativeFunctionDeclaration.parameters())
- newNameResolver.checkErrorAndVisit(parameter);
-}
-
void NameResolver::visit(AST::Block& block)
{
NameContext nameContext(&m_nameContext);
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameResolver.h (246542 => 246543)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameResolver.h 2019-06-18 16:41:40 UTC (rev 246542)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameResolver.h 2019-06-18 16:44:36 UTC (rev 246543)
@@ -43,6 +43,8 @@
virtual ~NameResolver() = default;
+ void visit(AST::FunctionDefinition&) override;
+
void setCurrentFunctionDefinition(AST::FunctionDefinition* functionDefinition)
{
m_currentFunction = functionDefinition;
@@ -49,8 +51,6 @@
}
private:
- void visit(AST::FunctionDefinition&) override;
- void visit(AST::NativeFunctionDeclaration&) override;
void visit(AST::TypeReference&) override;
void visit(AST::Block&) override;
void visit(AST::IfStatement&) override;
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt (246542 => 246543)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt 2019-06-18 16:41:40 UTC (rev 246542)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt 2019-06-18 16:44:36 UTC (rev 246543)
@@ -625,7 +625,4 @@
return result;
}
-native ushort Sample(Texture1D<ushort>, sampler, float location);
-native ushort Sample(Texture1D<ushort>, sampler, float location, int offset);
-
// FIXME: https://bugs.webkit.org/show_bug.cgi?id=192890 Insert the rest of the standard library once the parser is fast enough
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
