Title: [246548] trunk/Tools
- Revision
- 246548
- Author
- [email protected]
- Date
- 2019-06-18 10:20:10 -0700 (Tue, 18 Jun 2019)
Log Message
REGRESSION: _WKDownload.OriginatingWebView and _WKDownload.CrashAfterDownloadDidFinishWhenDownloadProxyHoldsTheLastRefOnWebProcessPool failing
https://bugs.webkit.org/show_bug.cgi?id=198954
rdar://problem/51711556
Reviewed by Alex Christensen.
For these tests, kill the web process after the download starts. This makes the deallocation
of the download-originating web views, which these tests depend on, more reliable.
* TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
(-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
(-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (246547 => 246548)
--- trunk/Tools/ChangeLog 2019-06-18 17:19:59 UTC (rev 246547)
+++ trunk/Tools/ChangeLog 2019-06-18 17:20:10 UTC (rev 246548)
@@ -1,3 +1,18 @@
+2019-06-18 David Quesada <[email protected]>
+
+ REGRESSION: _WKDownload.OriginatingWebView and _WKDownload.CrashAfterDownloadDidFinishWhenDownloadProxyHoldsTheLastRefOnWebProcessPool failing
+ https://bugs.webkit.org/show_bug.cgi?id=198954
+ rdar://problem/51711556
+
+ Reviewed by Alex Christensen.
+
+ For these tests, kill the web process after the download starts. This makes the deallocation
+ of the download-originating web views, which these tests depend on, more reliable.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
+ (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
+ (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
+
2019-06-18 Dan Bernstein <[email protected]>
Revert workaround for bug 198904 from run-webkit-archive
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm (246547 => 246548)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm 2019-06-18 17:19:59 UTC (rev 246547)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm 2019-06-18 17:20:10 UTC (rev 246548)
@@ -259,6 +259,7 @@
- (void)_downloadDidStart:(_WKDownload *)download
{
EXPECT_EQ([download originatingWebView], _webView);
+ [_webView _killWebContentProcessAndResetState];
_webView = nullptr;
WTF::callOnMainThread([download = retainPtr(download)] {
@@ -750,6 +751,7 @@
- (void)_downloadDidStart:(_WKDownload *)download
{
didDownloadStart = true;
+ [download.originatingWebView _killWebContentProcessAndResetState];
}
- (void)_downloadDidCancel:(_WKDownload *)download
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
