Title: [246618] trunk/Source/WebInspectorUI
- Revision
- 246618
- Author
- [email protected]
- Date
- 2019-06-19 17:15:55 -0700 (Wed, 19 Jun 2019)
Log Message
Web Inspector: Remove unused _pendingFilter from NetworkTableContentView
https://bugs.webkit.org/show_bug.cgi?id=199026
Reviewed by Devin Rousso.
This flag is no longer set as of https://trac.webkit.org/changeset/225895.
* UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView):
(WI.NetworkTableContentView.prototype._processPendingEntries):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (246617 => 246618)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-06-20 00:14:11 UTC (rev 246617)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-06-20 00:15:55 UTC (rev 246618)
@@ -1,3 +1,16 @@
+2019-06-19 Matt Baker <[email protected]>
+
+ Web Inspector: Remove unused _pendingFilter from NetworkTableContentView
+ https://bugs.webkit.org/show_bug.cgi?id=199026
+
+ Reviewed by Devin Rousso.
+
+ This flag is no longer set as of https://trac.webkit.org/changeset/225895.
+
+ * UserInterface/Views/NetworkTableContentView.js:
+ (WI.NetworkTableContentView):
+ (WI.NetworkTableContentView.prototype._processPendingEntries):
+
2019-06-19 Devin Rousso <[email protected]>
Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'sourceCodePosition.lineNumber')
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js (246617 => 246618)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js 2019-06-20 00:14:11 UTC (rev 246617)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js 2019-06-20 00:15:55 UTC (rev 246618)
@@ -39,7 +39,6 @@
this._entriesSortComparator = null;
- this._pendingFilter = false;
this._showingRepresentedObjectCookie = null;
this._table = null;
@@ -1333,10 +1332,9 @@
{
let collection = this._activeCollection;
let needsSort = collection.pendingUpdates.length > 0;
- let needsFilter = this._pendingFilter;
- // No global sort or filter is needed, so just insert new records into their sorted position.
- if (!needsSort && !needsFilter) {
+ // No global sort is needed, so just insert new records into their sorted position.
+ if (!needsSort) {
let originalLength = collection.pendingInsertions.length;
for (let resource of collection.pendingInsertions)
this._insertResourceAndReloadTable(resource);
@@ -1358,8 +1356,6 @@
}
collection.pendingUpdates = [];
- this._pendingFilter = false;
-
this._updateSort();
this._updateFilteredEntries();
this._reloadTable();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
