Title: [246656] trunk/Tools
- Revision
- 246656
- Author
- [email protected]
- Date
- 2019-06-20 15:25:12 -0700 (Thu, 20 Jun 2019)
Log Message
[ews-app] Status bubble should not turn orange when any build step is skipped
https://bugs.webkit.org/show_bug.cgi?id=199079
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py (246655 => 246656)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py 2019-06-20 22:06:51 UTC (rev 246655)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py 2019-06-20 22:25:12 UTC (rev 246656)
@@ -155,7 +155,7 @@
def _does_build_contains_any_failed_step(self, build):
for step in build.step_set.all():
- if step.result and step.result != Buildbot.SUCCESS and step.result != Buildbot.WARNINGS:
+ if step.result and step.result != Buildbot.SUCCESS and step.result != Buildbot.WARNINGS and step.result != Buildbot.SKIPPED:
return True
return False
Modified: trunk/Tools/ChangeLog (246655 => 246656)
--- trunk/Tools/ChangeLog 2019-06-20 22:06:51 UTC (rev 246655)
+++ trunk/Tools/ChangeLog 2019-06-20 22:25:12 UTC (rev 246656)
@@ -1,3 +1,12 @@
+2019-06-20 Aakash Jain <[email protected]>
+
+ [ews-app] Status bubble should not turn orange when any build step is skipped
+ https://bugs.webkit.org/show_bug.cgi?id=199079
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+
2019-06-20 Alex Christensen <[email protected]>
Fix an internal engineering build after r246605
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
