Title: [246731] trunk/Source/WebCore
- Revision
- 246731
- Author
- ctur...@igalia.com
- Date
- 2019-06-24 04:33:30 -0700 (Mon, 24 Jun 2019)
Log Message
[GStreamer][MSE] Pausing video sometimes causes skip to finish
https://bugs.webkit.org/show_bug.cgi?id=197355
Reviewed by Philippe Normand.
Covered by existing tests.
* platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::currentMediaTime const):
Assuming that when m_eosPending is on and we're paused() that the
network resource is fully loaded and the end is reached is clearly
wrong. Whether this is now correct is unclear...
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (246730 => 246731)
--- trunk/Source/WebCore/ChangeLog 2019-06-24 11:27:05 UTC (rev 246730)
+++ trunk/Source/WebCore/ChangeLog 2019-06-24 11:33:30 UTC (rev 246731)
@@ -1,5 +1,20 @@
2019-06-24 Charlie Turner <ctur...@igalia.com>
+ [GStreamer][MSE] Pausing video sometimes causes skip to finish
+ https://bugs.webkit.org/show_bug.cgi?id=197355
+
+ Reviewed by Philippe Normand.
+
+ Covered by existing tests.
+
+ * platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
+ (WebCore::MediaPlayerPrivateGStreamerMSE::currentMediaTime const):
+ Assuming that when m_eosPending is on and we're paused() that the
+ network resource is fully loaded and the end is reached is clearly
+ wrong. Whether this is now correct is unclear...
+
+2019-06-24 Charlie Turner <ctur...@igalia.com>
+
[GStreamer] Volume level sometimes changes inappropriately
https://bugs.webkit.org/show_bug.cgi?id=197358
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp (246730 => 246731)
--- trunk/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp 2019-06-24 11:27:05 UTC (rev 246730)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp 2019-06-24 11:33:30 UTC (rev 246731)
@@ -758,7 +758,7 @@
{
MediaTime position = MediaPlayerPrivateGStreamer::currentMediaTime();
- if (m_eosPending && (paused() || (position >= durationMediaTime()))) {
+ if (m_eosPending && position >= durationMediaTime()) {
if (m_networkState != MediaPlayer::Loaded) {
m_networkState = MediaPlayer::Loaded;
m_player->networkStateChanged();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
