Title: [246754] trunk/Source/WebKit
- Revision
- 246754
- Author
- pvol...@apple.com
- Date
- 2019-06-24 12:32:03 -0700 (Mon, 24 Jun 2019)
Log Message
[Cocoa] Avoid creating a PlatformMediaSessionManager when the WebProcess is suspended or resumed
https://bugs.webkit.org/show_bug.cgi?id=199160
Reviewed by Brent Fulgham.
When the WebProcess suspends or resumes, the PlatformMediaSessionManager is notified about this.
Avoid creating a new PlatformMediaSessionManager if it does not already exist.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::actualPrepareToSuspend):
(WebKit::WebProcess::cancelPrepareToSuspend):
(WebKit::WebProcess::processDidResume):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (246753 => 246754)
--- trunk/Source/WebKit/ChangeLog 2019-06-24 19:02:40 UTC (rev 246753)
+++ trunk/Source/WebKit/ChangeLog 2019-06-24 19:32:03 UTC (rev 246754)
@@ -1,3 +1,18 @@
+2019-06-24 Per Arne Vollan <pvol...@apple.com>
+
+ [Cocoa] Avoid creating a PlatformMediaSessionManager when the WebProcess is suspended or resumed
+ https://bugs.webkit.org/show_bug.cgi?id=199160
+
+ Reviewed by Brent Fulgham.
+
+ When the WebProcess suspends or resumes, the PlatformMediaSessionManager is notified about this.
+ Avoid creating a new PlatformMediaSessionManager if it does not already exist.
+
+ * WebProcess/WebProcess.cpp:
+ (WebKit::WebProcess::actualPrepareToSuspend):
+ (WebKit::WebProcess::cancelPrepareToSuspend):
+ (WebKit::WebProcess::processDidResume):
+
2019-06-24 Adrian Perez de Castro <ape...@igalia.com>
[WPE][GTK] Fixes for compilation with unified builds disabled
Modified: trunk/Source/WebKit/WebProcess/WebProcess.cpp (246753 => 246754)
--- trunk/Source/WebKit/WebProcess/WebProcess.cpp 2019-06-24 19:02:40 UTC (rev 246753)
+++ trunk/Source/WebKit/WebProcess/WebProcess.cpp 2019-06-24 19:32:03 UTC (rev 246754)
@@ -1473,7 +1473,8 @@
#if ENABLE(VIDEO)
suspendAllMediaBuffering();
- PlatformMediaSessionManager::sharedManager().processWillSuspend();
+ if (auto* platformMediaSessionManager = PlatformMediaSessionManager::sharedManagerIfExists())
+ platformMediaSessionManager->processWillSuspend();
#endif
if (!m_suppressMemoryPressureHandler)
@@ -1535,7 +1536,8 @@
#endif
#if ENABLE(VIDEO)
- PlatformMediaSessionManager::sharedManager().processDidResume();
+ if (auto* platformMediaSessionManager = PlatformMediaSessionManager::sharedManagerIfExists())
+ platformMediaSessionManager->processDidResume();
resumeAllMediaBuffering();
#endif
@@ -1611,7 +1613,8 @@
#endif
#if ENABLE(VIDEO)
- PlatformMediaSessionManager::sharedManager().processDidResume();
+ if (auto* platformMediaSessionManager = PlatformMediaSessionManager::sharedManagerIfExists())
+ platformMediaSessionManager->processDidResume();
resumeAllMediaBuffering();
#endif
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
