Title: [102690] trunk
- Revision
- 102690
- Author
- [email protected]
- Date
- 2011-12-13 10:34:11 -0800 (Tue, 13 Dec 2011)
Log Message
CSS 2.1 failure: eof-002.htm fails
https://bugs.webkit.org/show_bug.cgi?id=74309
Reviewed by Dean Jackson.
Source/WebCore:
Test: css2.1/20110323/eof-002-expected.html
* css/CSSGrammar.y: Treat EOF during a function _expression_ with an open parenthesis as a close parenthesis.
LayoutTests:
* css2.1/20110323/eof-002-expected.html: Added.
* css2.1/20110323/eof-002.htm: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (102689 => 102690)
--- trunk/LayoutTests/ChangeLog 2011-12-13 18:23:18 UTC (rev 102689)
+++ trunk/LayoutTests/ChangeLog 2011-12-13 18:34:11 UTC (rev 102690)
@@ -1,3 +1,13 @@
+2011-12-12 Robert Hogan <[email protected]>
+
+ CSS 2.1 failure: eof-002.htm fails
+ https://bugs.webkit.org/show_bug.cgi?id=74309
+
+ Reviewed by Dean Jackson.
+
+ * css2.1/20110323/eof-002-expected.html: Added.
+ * css2.1/20110323/eof-002.htm: Added.
+
2011-12-13 Mike Reed <[email protected]>
[skia] need new baselines when SKIA_TEXT is enabled
Added: trunk/LayoutTests/css2.1/20110323/eof-002-expected.html (0 => 102690)
--- trunk/LayoutTests/css2.1/20110323/eof-002-expected.html (rev 0)
+++ trunk/LayoutTests/css2.1/20110323/eof-002-expected.html 2011-12-13 18:34:11 UTC (rev 102690)
@@ -0,0 +1,16 @@
+<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">
+<html>
+ <head>
+ <title>CSS Test: Reference Result</title>
+ <style type="text/css">
+ div
+ {
+ color: rgb(0, 128, 0)
+ }
+ </style>
+ </head>
+ <body>
+ <p>Test passes if the "Filler Text" below is green.</p>
+ <div>Filler Text</div>
+ </body>
+</html>
\ No newline at end of file
Property changes on: trunk/LayoutTests/css2.1/20110323/eof-002-expected.html
___________________________________________________________________
Added: svn:eol-style
Added: trunk/LayoutTests/css2.1/20110323/eof-002.htm (0 => 102690)
--- trunk/LayoutTests/css2.1/20110323/eof-002.htm (rev 0)
+++ trunk/LayoutTests/css2.1/20110323/eof-002.htm 2011-12-13 18:34:11 UTC (rev 102690)
@@ -0,0 +1,19 @@
+<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">
+<html>
+ <head>
+ <title>CSS Test: Parsing unexpected end of function</title>
+ <link rel="author" title="Microsoft" href=""
+ <link rel="help" href=""
+ <meta name="flags" content="invalid">
+ <meta name="assert" content="User agents close all open parentheses at the end of the style sheet.">
+ <style type="text/css">
+ div
+ {
+ color: rgb(0, 128, 0
+ </style>
+ </head>
+ <body>
+ <p>Test passes if the "Filler Text" below is green.</p>
+ <div>Filler Text</div>
+ </body>
+</html>
\ No newline at end of file
Property changes on: trunk/LayoutTests/css2.1/20110323/eof-002.htm
___________________________________________________________________
Added: svn:eol-style
Modified: trunk/Source/WebCore/ChangeLog (102689 => 102690)
--- trunk/Source/WebCore/ChangeLog 2011-12-13 18:23:18 UTC (rev 102689)
+++ trunk/Source/WebCore/ChangeLog 2011-12-13 18:34:11 UTC (rev 102690)
@@ -1,3 +1,14 @@
+2011-12-12 Robert Hogan <[email protected]>
+
+ CSS 2.1 failure: eof-002.htm fails
+ https://bugs.webkit.org/show_bug.cgi?id=74309
+
+ Reviewed by Dean Jackson.
+
+ Test: css2.1/20110323/eof-002-expected.html
+
+ * css/CSSGrammar.y: Treat EOF during a function _expression_ with an open parenthesis as a close parenthesis.
+
2011-12-13 Adam Klein <[email protected]>
V8Proxy cleanup: replace custom logging methods with standard WebCore calls
Modified: trunk/Source/WebCore/css/CSSGrammar.y (102689 => 102690)
--- trunk/Source/WebCore/css/CSSGrammar.y 2011-12-13 18:23:18 UTC (rev 102689)
+++ trunk/Source/WebCore/css/CSSGrammar.y 2011-12-13 18:34:11 UTC (rev 102690)
@@ -1484,6 +1484,15 @@
$$.unit = CSSParserValue::Function;
$$.function = f;
} |
+ FUNCTION maybe_space expr TOKEN_EOF {
+ CSSParser* p = static_cast<CSSParser*>(parser);
+ CSSParserFunction* f = p->createFloatingFunction();
+ f->name = $1;
+ f->args = adoptPtr(p->sinkFloatingValueList($3));
+ $$.id = 0;
+ $$.unit = CSSParserValue::Function;
+ $$.function = f;
+ } |
FUNCTION maybe_space ')' maybe_space {
CSSParser* p = static_cast<CSSParser*>(parser);
CSSParserFunction* f = p->createFloatingFunction();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
