Title: [246899] trunk/Source/WebCore
Revision
246899
Author
[email protected]
Date
2019-06-27 13:22:16 -0700 (Thu, 27 Jun 2019)

Log Message

REGRESSION (r246869): ASSERTION FAILED: !renderer().hasRepaintLayoutRects() || renderer().repaintLayoutRects().m_repaintRect == renderer().clippedOverflowRectForRepaint(renderer().containerForRepaint())
https://bugs.webkit.org/show_bug.cgi?id=199274

Reviewed by Zalan Bujtas.

When layer backing sharing changes, we need to clear cached repaint rects, since they
painting root changes.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setBackingProviderLayer):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (246898 => 246899)


--- trunk/Source/WebCore/ChangeLog	2019-06-27 20:00:40 UTC (rev 246898)
+++ trunk/Source/WebCore/ChangeLog	2019-06-27 20:22:16 UTC (rev 246899)
@@ -1,3 +1,16 @@
+2019-06-27  Simon Fraser  <[email protected]>
+
+        REGRESSION (r246869): ASSERTION FAILED: !renderer().hasRepaintLayoutRects() || renderer().repaintLayoutRects().m_repaintRect == renderer().clippedOverflowRectForRepaint(renderer().containerForRepaint())
+        https://bugs.webkit.org/show_bug.cgi?id=199274
+
+        Reviewed by Zalan Bujtas.
+
+        When layer backing sharing changes, we need to clear cached repaint rects, since they
+        painting root changes.
+
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::setBackingProviderLayer):
+
 2019-06-27  Beth Dakin  <[email protected]>
 
         Upstream use of MACCATALYST

Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (246898 => 246899)


--- trunk/Source/WebCore/rendering/RenderLayer.cpp	2019-06-27 20:00:40 UTC (rev 246898)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp	2019-06-27 20:22:16 UTC (rev 246899)
@@ -1788,8 +1788,10 @@
     if (backingProvider == m_backingProviderLayer)
         return;
 
-    if (!renderer().renderTreeBeingDestroyed())
+    if (!renderer().renderTreeBeingDestroyed()) {
+        clearRepaintRects();
         clearClipRectsIncludingDescendants();
+    }
 
     m_backingProviderLayer = makeWeakPtr(backingProvider);
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to