Title: [246945] trunk/Source/ThirdParty/libwebrtc
Revision
246945
Author
d...@apple.com
Date
2019-06-28 15:50:41 -0700 (Fri, 28 Jun 2019)

Log Message

unable to build WebRTC for iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=199337
<rdar://problem/52020841>

Reviewed by Tim Horton.

Run the compiled yasm with DYLD_ROOT_PATH=/
in order to convince dyld that it can load
the simulator binary on macOS.

* libwebrtc.xcodeproj/project.pbxproj:

Modified Paths

Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (246944 => 246945)


--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2019-06-28 22:48:13 UTC (rev 246944)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2019-06-28 22:50:41 UTC (rev 246945)
@@ -1,3 +1,17 @@
+2019-06-28  Dean Jackson  <d...@apple.com>
+
+        unable to build WebRTC for iOS Simulator
+        https://bugs.webkit.org/show_bug.cgi?id=199337
+        <rdar://problem/52020841>
+
+        Reviewed by Tim Horton.
+
+        Run the compiled yasm with DYLD_ROOT_PATH=/
+        in order to convince dyld that it can load
+        the simulator binary on macOS.
+
+        * libwebrtc.xcodeproj/project.pbxproj:
+
 2019-06-27  Beth Dakin  <bda...@apple.com>
 
         Upstream use of MACCATALYST

Modified: trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj (246944 => 246945)


--- trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj	2019-06-28 22:48:13 UTC (rev 246944)
+++ trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj	2019-06-28 22:50:41 UTC (rev 246945)
@@ -3375,11 +3375,13 @@
 			compilerSpec = com.apple.compilers.proxy.script;
 			filePatterns = asm;
 			fileType = sourcecode.asm.asm;
+			inputFiles = (
+			);
 			isEditable = 1;
 			outputFiles = (
 				"${OBJECT_FILE_DIR_normal}/${CURRENT_ARCH}/${INPUT_FILE_BASE}.o",
 			);
-			script = "${BUILT_PRODUCTS_DIR}/yasm -fmacho64 -I ${SRCROOT}/Source/third_party/libvpx/source/config -I ${SRCROOT}/Source/third_party/libvpx/source/config/mac/x64 -I ${SRCROOT}/Source/third_party/libvpx/source/libvpx -o ${OBJECT_FILE_DIR_normal}/${CURRENT_ARCH}/${INPUT_FILE_BASE}.o ${INPUT_FILE_DIR}/${INPUT_FILE_BASE}.asm\n";
+			script = "# This DYLD_ROOT_PATH hack is there to allow the yasm binary to run on macOS if it was built for another platform (e.g. iphonesimulator) - rdar://52020841 and rdar://50479465\nDYLD_ROOT_PATH=/ ${BUILT_PRODUCTS_DIR}/yasm -fmacho64 -I ${SRCROOT}/Source/third_party/libvpx/source/config -I ${SRCROOT}/Source/third_party/libvpx/source/config/mac/x64 -I ${SRCROOT}/Source/third_party/libvpx/source/libvpx -o ${OBJECT_FILE_DIR_normal}/${CURRENT_ARCH}/${INPUT_FILE_BASE}.o ${INPUT_FILE_DIR}/${INPUT_FILE_BASE}.asm\n";
 		};
 /* End PBXBuildRule section */
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to