Title: [246966] releases/WebKitGTK/webkit-2.24/Source/_javascript_Core
- Revision
- 246966
- Author
- [email protected]
- Date
- 2019-07-01 01:52:52 -0700 (Mon, 01 Jul 2019)
Log Message
Merge r246151 - aarch64: ‘JSC::ARM64Assembler::LinkRecord::<unnamed union>::RealTypes::m_compareRegister’ is too small to hold all values of ‘JSC::ARM64Assembler::RegisterID’ {aka ‘enum JSC::ARM64Registers::RegisterID’}
https://bugs.webkit.org/show_bug.cgi?id=198014
Reviewed by Yusuke Suzuki.
When building for aarch64, there is a huge warning spam here. It's impossible to see any
other warnings. This has been ongoing for so long I've begun to suspect that nobody works
on this architecture.
Anyway, the problem is because we need eight bits to store all possible RegisterID values,
but the bitfield is only six bits wide. Fix it. The COMPILE_ASSERT checking the size of this
struct is still happy, so I presume the change is OK.
* assembler/ARM64Assembler.h:
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.24/Source/_javascript_Core/ChangeLog (246965 => 246966)
--- releases/WebKitGTK/webkit-2.24/Source/_javascript_Core/ChangeLog 2019-07-01 08:27:07 UTC (rev 246965)
+++ releases/WebKitGTK/webkit-2.24/Source/_javascript_Core/ChangeLog 2019-07-01 08:52:52 UTC (rev 246966)
@@ -1,3 +1,20 @@
+2019-06-06 Michael Catanzaro <[email protected]>
+
+ aarch64: ‘JSC::ARM64Assembler::LinkRecord::<unnamed union>::RealTypes::m_compareRegister’ is too small to hold all values of ‘JSC::ARM64Assembler::RegisterID’ {aka ‘enum JSC::ARM64Registers::RegisterID’}
+ https://bugs.webkit.org/show_bug.cgi?id=198014
+
+ Reviewed by Yusuke Suzuki.
+
+ When building for aarch64, there is a huge warning spam here. It's impossible to see any
+ other warnings. This has been ongoing for so long I've begun to suspect that nobody works
+ on this architecture.
+
+ Anyway, the problem is because we need eight bits to store all possible RegisterID values,
+ but the bitfield is only six bits wide. Fix it. The COMPILE_ASSERT checking the size of this
+ struct is still happy, so I presume the change is OK.
+
+ * assembler/ARM64Assembler.h:
+
2019-05-20 Carlos Garcia Campos <[email protected]>
[GLIB] Crash when instantiating a js object registered with jsc_context_register_class on window object cleared
Modified: releases/WebKitGTK/webkit-2.24/Source/_javascript_Core/assembler/ARM64Assembler.h (246965 => 246966)
--- releases/WebKitGTK/webkit-2.24/Source/_javascript_Core/assembler/ARM64Assembler.h 2019-07-01 08:27:07 UTC (rev 246965)
+++ releases/WebKitGTK/webkit-2.24/Source/_javascript_Core/assembler/ARM64Assembler.h 2019-07-01 08:52:52 UTC (rev 246966)
@@ -458,11 +458,11 @@
struct RealTypes {
int64_t m_from;
int64_t m_to;
+ RegisterID m_compareRegister;
JumpType m_type : 8;
JumpLinkType m_linkType : 8;
Condition m_condition : 4;
unsigned m_bitNumber : 6;
- RegisterID m_compareRegister : 6;
bool m_is64Bit : 1;
} realTypes;
struct CopyTypes {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
