Title: [246989] releases/WebKitGTK/webkit-2.24/Source/WebCore
- Revision
- 246989
- Author
- [email protected]
- Date
- 2019-07-01 04:03:12 -0700 (Mon, 01 Jul 2019)
Log Message
Merge r245464 - Hardening: Prevent FrameLoader crash due to SetForScope
https://bugs.webkit.org/show_bug.cgi?id=197458
<rdar://problem/50368338>
Reviewed by Chris Dumez.
Since SetForScope takes action during a function returns, it might cause
a crash if its scope is broader than the value it is resetting.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadDifferentDocumentItem):
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog (246988 => 246989)
--- releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog 2019-07-01 09:22:16 UTC (rev 246988)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog 2019-07-01 11:03:12 UTC (rev 246989)
@@ -1,3 +1,17 @@
+2019-05-17 Brent Fulgham <[email protected]>
+
+ Hardening: Prevent FrameLoader crash due to SetForScope
+ https://bugs.webkit.org/show_bug.cgi?id=197458
+ <rdar://problem/50368338>
+
+ Reviewed by Chris Dumez.
+
+ Since SetForScope takes action during a function returns, it might cause
+ a crash if its scope is broader than the value it is resetting.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::loadDifferentDocumentItem):
+
2019-07-01 Miguel Gomez <[email protected]>
[WPE][GTK] Content disappearing when using CSS transforms
Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/loader/FrameLoader.cpp (246988 => 246989)
--- releases/WebKitGTK/webkit-2.24/Source/WebCore/loader/FrameLoader.cpp 2019-07-01 09:22:16 UTC (rev 246988)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/loader/FrameLoader.cpp 2019-07-01 11:03:12 UTC (rev 246989)
@@ -3691,6 +3691,8 @@
{
RELEASE_LOG_IF_ALLOWED("loadDifferentDocumentItem: frame load started (frame = %p, main = %d)", &m_frame, m_frame.isMainFrame());
+ Ref<Frame> protectedFrame(m_frame);
+
// History items should not be reported to the parent.
m_shouldReportResourceTimingToParentFrame = false;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
