Title: [247086] trunk/LayoutTests
Revision
247086
Author
[email protected]
Date
2019-07-02 20:42:00 -0700 (Tue, 02 Jul 2019)

Log Message

imported/blink/animations/display-inline-style-adjust.html isn't a valid ref test
https://bugs.webkit.org/show_bug.cgi?id=199311

Reviewed by Simon Fraser.

These tests are depending on platform font metrics. They were
created for a Blink bug, doesn't seem useful for WebKit. Just
removed them.

* imported/blink/animations/display-inline-style-adjust.html: Deleted.
* legacy-animation-engine/imported/blink/animations/display-inline-style-adjust.html: Deleted.
* platform/gtk/TestExpectations: Unmarked them.
* platform/ios/TestExpectations: Ditto.
* platform/wpe/TestExpectations: Ditto.

Modified Paths

Removed Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (247085 => 247086)


--- trunk/LayoutTests/ChangeLog	2019-07-03 01:41:59 UTC (rev 247085)
+++ trunk/LayoutTests/ChangeLog	2019-07-03 03:42:00 UTC (rev 247086)
@@ -1,3 +1,20 @@
+2019-07-02  Fujii Hironori  <[email protected]>
+
+        imported/blink/animations/display-inline-style-adjust.html isn't a valid ref test
+        https://bugs.webkit.org/show_bug.cgi?id=199311
+
+        Reviewed by Simon Fraser.
+
+        These tests are depending on platform font metrics. They were
+        created for a Blink bug, doesn't seem useful for WebKit. Just
+        removed them.
+
+        * imported/blink/animations/display-inline-style-adjust.html: Deleted.
+        * legacy-animation-engine/imported/blink/animations/display-inline-style-adjust.html: Deleted.
+        * platform/gtk/TestExpectations: Unmarked them.
+        * platform/ios/TestExpectations: Ditto.
+        * platform/wpe/TestExpectations: Ditto.
+
 2019-07-02  Said Abou-Hallawa  <[email protected]>
 
         Assertion fires when animating the 'class' attribute of an SVG element

Deleted: trunk/LayoutTests/imported/blink/animations/display-inline-style-adjust-expected.html (247085 => 247086)


--- trunk/LayoutTests/imported/blink/animations/display-inline-style-adjust-expected.html	2019-07-03 01:41:59 UTC (rev 247085)
+++ trunk/LayoutTests/imported/blink/animations/display-inline-style-adjust-expected.html	2019-07-03 03:42:00 UTC (rev 247086)
@@ -1,12 +0,0 @@
-<!DOCTYPE html>
-<style>
-div {
-  position: absolute;
-  top: 4em;
-  width: 400px;
-}
-</style>
-
-<div>
-  <span>This sentence should span a single line.</span>
-</div>

Deleted: trunk/LayoutTests/imported/blink/animations/display-inline-style-adjust.html (247085 => 247086)


--- trunk/LayoutTests/imported/blink/animations/display-inline-style-adjust.html	2019-07-03 01:41:59 UTC (rev 247085)
+++ trunk/LayoutTests/imported/blink/animations/display-inline-style-adjust.html	2019-07-03 03:42:00 UTC (rev 247086)
@@ -1,21 +0,0 @@
-<!DOCTYPE html>
-<style>
-@keyframes test {
-  from { background-position: 0 0;}
-  to { background-position: 1px 1px;}
-}
-div {
-  position: absolute;
-  top: 4em;
-  width: 400px;
-}
-.animated {
-  position: absolute;
-  animation: test 1000s;
-}
-</style>
-
-<div>
-  <span>This sentence shoul</span>
-  <span class="animated">d span a single line.</span>
-</div>

Deleted: trunk/LayoutTests/legacy-animation-engine/imported/blink/animations/display-inline-style-adjust-expected.html (247085 => 247086)


--- trunk/LayoutTests/legacy-animation-engine/imported/blink/animations/display-inline-style-adjust-expected.html	2019-07-03 01:41:59 UTC (rev 247085)
+++ trunk/LayoutTests/legacy-animation-engine/imported/blink/animations/display-inline-style-adjust-expected.html	2019-07-03 03:42:00 UTC (rev 247086)
@@ -1,12 +0,0 @@
-<!DOCTYPE html><!-- webkit-test-runner [ experimental:WebAnimationsCSSIntegrationEnabled=false ] -->
-<style>
-div {
-  position: absolute;
-  top: 4em;
-  width: 400px;
-}
-</style>
-
-<div>
-  <span>This sentence should span a single line.</span>
-</div>

Deleted: trunk/LayoutTests/legacy-animation-engine/imported/blink/animations/display-inline-style-adjust.html (247085 => 247086)


--- trunk/LayoutTests/legacy-animation-engine/imported/blink/animations/display-inline-style-adjust.html	2019-07-03 01:41:59 UTC (rev 247085)
+++ trunk/LayoutTests/legacy-animation-engine/imported/blink/animations/display-inline-style-adjust.html	2019-07-03 03:42:00 UTC (rev 247086)
@@ -1,21 +0,0 @@
-<!DOCTYPE html><!-- webkit-test-runner [ experimental:WebAnimationsCSSIntegrationEnabled=false ] -->
-<style>
-@keyframes test {
-  from { background-position: 0 0;}
-  to { background-position: 1px 1px;}
-}
-div {
-  position: absolute;
-  top: 4em;
-  width: 400px;
-}
-.animated {
-  position: absolute;
-  animation: test 1000s;
-}
-</style>
-
-<div>
-  <span>This sentence shoul</span>
-  <span class="animated">d span a single line.</span>
-</div>

Modified: trunk/LayoutTests/platform/gtk/TestExpectations (247085 => 247086)


--- trunk/LayoutTests/platform/gtk/TestExpectations	2019-07-03 01:41:59 UTC (rev 247085)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2019-07-03 03:42:00 UTC (rev 247086)
@@ -3323,7 +3323,6 @@
 
 # [GTK] Some reftest fail with only one or two pixel differences in diff image
 webkit.org/b/168426 fast/multicol/columns-on-body.html [ ImageOnlyFailure ]
-webkit.org/b/168426 legacy-animation-engine/imported/blink/animations/display-inline-style-adjust.html [ ImageOnlyFailure ]
 webkit.org/b/168426 fast/html/details-comment-crash.html [ ImageOnlyFailure ]
 webkit.org/b/168426 svg/clip-path/clip-opacity.html [ ImageOnlyFailure ]
 

Modified: trunk/LayoutTests/platform/ios/TestExpectations (247085 => 247086)


--- trunk/LayoutTests/platform/ios/TestExpectations	2019-07-03 01:41:59 UTC (rev 247085)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2019-07-03 03:42:00 UTC (rev 247086)
@@ -2247,8 +2247,6 @@
 legacy-animation-engine/imported/blink/animations/background-shorthand-crash.html [ Pass Timeout ]
 imported/blink/animations/base-render-style-font-selector-version-assert.html [ Pass Timeout ]
 legacy-animation-engine/imported/blink/animations/base-render-style-font-selector-version-assert.html [ Pass Timeout ]
-imported/blink/animations/display-inline-style-adjust.html [ ImageOnlyFailure Pass ]
-legacy-animation-engine/imported/blink/animations/display-inline-style-adjust.html [ ImageOnlyFailure Pass ]
 imported/blink/compositing/draws-content/canvas-simple-background.html [ ImageOnlyFailure Pass ]
 imported/blink/compositing/draws-content/webgl-simple-background.html [ ImageOnlyFailure Pass ]
 imported/blink/compositing/layer-creation/iframe-clip-removed.html [ Pass Timeout ]

Modified: trunk/LayoutTests/platform/wpe/TestExpectations (247085 => 247086)


--- trunk/LayoutTests/platform/wpe/TestExpectations	2019-07-03 01:41:59 UTC (rev 247085)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2019-07-03 03:42:00 UTC (rev 247086)
@@ -1348,7 +1348,6 @@
 
 webkit.org/b/186754 legacy-animation-engine/accessibility/transformed-bounds.html [ Failure ]
 webkit.org/b/186252 legacy-animation-engine/css3/filters/backdrop/animation.html [ Timeout ]
-webkit.org/b/168426 legacy-animation-engine/imported/blink/animations/display-inline-style-adjust.html [ ImageOnlyFailure ]
 
 webkit.org/b/187044 webanimations/opacity-animation-yields-compositing-span.html [ Failure ]
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to