Title: [247093] trunk
- Revision
- 247093
- Author
- [email protected]
- Date
- 2019-07-03 10:40:38 -0700 (Wed, 03 Jul 2019)
Log Message
Safari hanging while loading pages - WebCore::AccessibilityRenderObject::visiblePositionRangeForLine.
https://bugs.webkit.org/show_bug.cgi?id=199434
<rdar://problem/52475140>
Patch by Andres Gonzalez <[email protected]> on 2019-07-03
Reviewed by Chris Fleizach.
Source/WebCore:
Tests were disabled until underlying bug is fixed.
Rolling out a workaround for CharacterIterator::advance bug because it
seems to be causing a hang in Safari.
* editing/Editing.cpp:
(WebCore::visiblePositionForIndexUsingCharacterIterator):
LayoutTests:
Disabled the tests that were passing for workaround. The workaround had
to be roll out cause it is hanging Safari.
* TestExpectations:
* platform/ios-wk2/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (247092 => 247093)
--- trunk/LayoutTests/ChangeLog 2019-07-03 17:28:53 UTC (rev 247092)
+++ trunk/LayoutTests/ChangeLog 2019-07-03 17:40:38 UTC (rev 247093)
@@ -1,3 +1,16 @@
+2019-07-03 Andres Gonzalez <[email protected]>
+
+ Safari hanging while loading pages - WebCore::AccessibilityRenderObject::visiblePositionRangeForLine.
+ https://bugs.webkit.org/show_bug.cgi?id=199434
+ <rdar://problem/52475140>
+
+ Reviewed by Chris Fleizach.
+
+ Disabled the tests that were passing for workaround. The workaround had
+ to be roll out cause it is hanging Safari.
+ * TestExpectations:
+ * platform/ios-wk2/TestExpectations:
+
2019-07-02 Fujii Hironori <[email protected]>
imported/blink/animations/display-inline-style-adjust.html isn't a valid ref test
Modified: trunk/LayoutTests/TestExpectations (247092 => 247093)
--- trunk/LayoutTests/TestExpectations 2019-07-03 17:28:53 UTC (rev 247092)
+++ trunk/LayoutTests/TestExpectations 2019-07-03 17:40:38 UTC (rev 247093)
@@ -2204,6 +2204,7 @@
########################################
### START OF -disabled tests
+webkit.org/b/199431 accessibility/set-selected-text-range-after-newline.html [ Skip ]
webkit.org/b/20871 js/garbage-collect-after-string-appends.html [ Skip ]
webkit.org/b/58323 compositing/objects/composited-object-alignment.html [ Skip ]
webkit.org/b/48454 compositing/tiling/huge-layer-resize.html [ Skip ]
Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (247092 => 247093)
--- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2019-07-03 17:28:53 UTC (rev 247092)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2019-07-03 17:40:38 UTC (rev 247093)
@@ -994,6 +994,7 @@
fast/forms/input-appearance-spinbutton.html [ Failure ]
fast/replaced/border-radius-clip.html [ Failure ]
accessibility/ios-simulator/press-fires-touch-events.html [ Skip ]
+webkit.org/b/199431 accessibility/ios-simulator/set-selected-text-range-after-newline.html [ Skip ]
fast/text/combining-character-sequence-vertical.html [ ImageOnlyFailure ]
fast/text/vertical-quotation-marks.html [ ImageOnlyFailure ]
Modified: trunk/Source/WebCore/ChangeLog (247092 => 247093)
--- trunk/Source/WebCore/ChangeLog 2019-07-03 17:28:53 UTC (rev 247092)
+++ trunk/Source/WebCore/ChangeLog 2019-07-03 17:40:38 UTC (rev 247093)
@@ -1,3 +1,18 @@
+2019-07-03 Andres Gonzalez <[email protected]>
+
+ Safari hanging while loading pages - WebCore::AccessibilityRenderObject::visiblePositionRangeForLine.
+ https://bugs.webkit.org/show_bug.cgi?id=199434
+ <rdar://problem/52475140>
+
+ Reviewed by Chris Fleizach.
+
+ Tests were disabled until underlying bug is fixed.
+
+ Rolling out a workaround for CharacterIterator::advance bug because it
+ seems to be causing a hang in Safari.
+ * editing/Editing.cpp:
+ (WebCore::visiblePositionForIndexUsingCharacterIterator):
+
2019-07-02 Simon Fraser <[email protected]>
REGRESSION (r246723): ScrollingTreeOverflowScrollProxyNode::m_overflowScrollingNodeID is uninitialized sometimes
Modified: trunk/Source/WebCore/editing/Editing.cpp (247092 => 247093)
--- trunk/Source/WebCore/editing/Editing.cpp 2019-07-03 17:28:53 UTC (rev 247092)
+++ trunk/Source/WebCore/editing/Editing.cpp 2019-07-03 17:40:38 UTC (rev 247093)
@@ -1122,16 +1122,6 @@
CharacterIterator it(range.get());
it.advance(index - 1);
- if (!it.atEnd() && it.text()[0] == '\n') {
- // FIXME: workaround for collapsed range (where only start position is correct) emitted for some emitted newlines.
- auto range = it.range();
- if (range->startPosition() == range->endPosition()) {
- it.advance(1);
- if (!it.atEnd())
- return VisiblePosition(it.range()->startPosition());
- }
- }
-
return { it.atEnd() ? range->endPosition() : it.range()->endPosition(), UPSTREAM };
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
