Diff
Modified: trunk/Source/WTF/ChangeLog (247094 => 247095)
--- trunk/Source/WTF/ChangeLog 2019-07-03 17:48:41 UTC (rev 247094)
+++ trunk/Source/WTF/ChangeLog 2019-07-03 18:11:19 UTC (rev 247095)
@@ -1,3 +1,17 @@
+2019-07-03 Ryan Haddad <[email protected]>
+
+ Unreviewed, rolling out r246616.
+
+ Caused http/tests/inspector/network/har/har-page.html to fail
+ on Catalina.
+
+ Reverted changeset:
+
+ "Web Inspector: Network: replace CFNetwork SPI with new API
+ where able"
+ https://bugs.webkit.org/show_bug.cgi?id=198762
+ https://trac.webkit.org/changeset/246616
+
2019-07-02 Commit Queue <[email protected]>
Unreviewed, rolling out r247041.
Modified: trunk/Source/WTF/wtf/Platform.h (247094 => 247095)
--- trunk/Source/WTF/wtf/Platform.h 2019-07-03 17:48:41 UTC (rev 247094)
+++ trunk/Source/WTF/wtf/Platform.h 2019-07-03 18:11:19 UTC (rev 247095)
@@ -1511,13 +1511,8 @@
#define HAVE_CFNETWORK_NSURLSESSION_STRICTRUSTEVALUATE 1
#endif
-#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 110000)
-#define HAVE_CFNETWORK_NSURLSESSIONTASKTRANSACTIONMETRICS_SPI 1
-#endif
-
#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000)
#define HAVE_CFNETWORK_NEGOTIATED_SSL_PROTOCOL_CIPHER 1
-#define HAVE_CFNETWORK_NSURLSESSIONTASKTRANSACTIONMETRICS_ADDITIONS 1
#endif
#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500
Modified: trunk/Source/WebCore/ChangeLog (247094 => 247095)
--- trunk/Source/WebCore/ChangeLog 2019-07-03 17:48:41 UTC (rev 247094)
+++ trunk/Source/WebCore/ChangeLog 2019-07-03 18:11:19 UTC (rev 247095)
@@ -1,3 +1,17 @@
+2019-07-03 Ryan Haddad <[email protected]>
+
+ Unreviewed, rolling out r246616.
+
+ Caused http/tests/inspector/network/har/har-page.html to fail
+ on Catalina.
+
+ Reverted changeset:
+
+ "Web Inspector: Network: replace CFNetwork SPI with new API
+ where able"
+ https://bugs.webkit.org/show_bug.cgi?id=198762
+ https://trac.webkit.org/changeset/246616
+
2019-07-03 Andres Gonzalez <[email protected]>
Safari hanging while loading pages - WebCore::AccessibilityRenderObject::visiblePositionRangeForLine.
Modified: trunk/Source/WebCore/PAL/ChangeLog (247094 => 247095)
--- trunk/Source/WebCore/PAL/ChangeLog 2019-07-03 17:48:41 UTC (rev 247094)
+++ trunk/Source/WebCore/PAL/ChangeLog 2019-07-03 18:11:19 UTC (rev 247095)
@@ -1,3 +1,17 @@
+2019-07-03 Ryan Haddad <[email protected]>
+
+ Unreviewed, rolling out r246616.
+
+ Caused http/tests/inspector/network/har/har-page.html to fail
+ on Catalina.
+
+ Reverted changeset:
+
+ "Web Inspector: Network: replace CFNetwork SPI with new API
+ where able"
+ https://bugs.webkit.org/show_bug.cgi?id=198762
+ https://trac.webkit.org/changeset/246616
+
2019-06-28 Brent Fulgham <[email protected]>
[FTW] Build WebCore
Modified: trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h (247094 => 247095)
--- trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h 2019-07-03 17:48:41 UTC (rev 247094)
+++ trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h 2019-07-03 18:11:19 UTC (rev 247095)
@@ -222,7 +222,7 @@
#endif
@end
-#if HAVE(CFNETWORK_NSURLSESSIONTASKTRANSACTIONMETRICS_SPI)
+#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 110000)
@interface NSURLSessionTaskTransactionMetrics ()
@property (copy, readonly) NSString* _remoteAddressAndPort;
@property (copy, readonly) NSUUID* _connectionIdentifier;
Modified: trunk/Source/WebCore/platform/network/NetworkLoadMetrics.h (247094 => 247095)
--- trunk/Source/WebCore/platform/network/NetworkLoadMetrics.h 2019-07-03 17:48:41 UTC (rev 247094)
+++ trunk/Source/WebCore/platform/network/NetworkLoadMetrics.h 2019-07-03 18:11:19 UTC (rev 247095)
@@ -176,8 +176,8 @@
HTTPHeaderMap requestHeaders;
- uint64_t requestHeaderBytesSent;
- uint64_t responseHeaderBytesReceived;
+ uint32_t requestHeaderBytesSent;
+ uint32_t responseHeaderBytesReceived;
uint64_t requestBodyBytesSent;
uint64_t responseBodyBytesReceived;
uint64_t responseBodyDecodedSize;
Modified: trunk/Source/WebKit/ChangeLog (247094 => 247095)
--- trunk/Source/WebKit/ChangeLog 2019-07-03 17:48:41 UTC (rev 247094)
+++ trunk/Source/WebKit/ChangeLog 2019-07-03 18:11:19 UTC (rev 247095)
@@ -1,3 +1,17 @@
+2019-07-03 Ryan Haddad <[email protected]>
+
+ Unreviewed, rolling out r246616.
+
+ Caused http/tests/inspector/network/har/har-page.html to fail
+ on Catalina.
+
+ Reverted changeset:
+
+ "Web Inspector: Network: replace CFNetwork SPI with new API
+ where able"
+ https://bugs.webkit.org/show_bug.cgi?id=198762
+ https://trac.webkit.org/changeset/246616
+
2019-07-03 Chris Dumez <[email protected]>
Crash under WTF::RefCounted<WebKit::TaskCounter>::deref()
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (247094 => 247095)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2019-07-03 17:48:41 UTC (rev 247094)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2019-07-03 18:11:19 UTC (rev 247095)
@@ -682,7 +682,7 @@
if (networkDataTask->shouldCaptureExtraNetworkLoadMetrics()) {
networkLoadMetrics.priority = toNetworkLoadPriority(task.priority);
-#if HAVE(CFNETWORK_NSURLSESSIONTASKTRANSACTIONMETRICS_SPI)
+#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 110000)
networkLoadMetrics.remoteAddress = String(m._remoteAddressAndPort);
networkLoadMetrics.connectionIdentifier = String([m._connectionIdentifier UUIDString]);
#endif
@@ -698,21 +698,7 @@
}];
networkLoadMetrics.requestHeaders = WTFMove(requestHeaders);
-#if HAVE(CFNETWORK_NSURLSESSIONTASKTRANSACTIONMETRICS_ADDITIONS)
- networkLoadMetrics.requestHeaderBytesSent = 0;
- networkLoadMetrics.requestBodyBytesSent = 0;
- networkLoadMetrics.responseHeaderBytesReceived = 0;
- networkLoadMetrics.responseBodyBytesReceived = 0;
- networkLoadMetrics.responseBodyDecodedSize = 0;
-
- for (NSURLSessionTaskTransactionMetrics *transactionMetrics in metrics.transactionMetrics) {
- networkLoadMetrics.requestHeaderBytesSent += transactionMetrics.countOfRequestHeaderBytesSent;
- networkLoadMetrics.requestBodyBytesSent += transactionMetrics.countOfRequestBodyBytesSent;
- networkLoadMetrics.responseHeaderBytesReceived += transactionMetrics.countOfResponseHeaderBytesReceived;
- networkLoadMetrics.responseBodyBytesReceived += transactionMetrics.countOfResponseBodyBytesReceived;
- networkLoadMetrics.responseBodyDecodedSize += transactionMetrics.countOfResponseBodyBytesAfterDecoding;
- }
-#elif HAVE(CFNETWORK_NSURLSESSIONTASKTRANSACTIONMETRICS_SPI)
+#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 110000)
uint64_t requestHeaderBytesSent = 0;
uint64_t responseHeaderBytesReceived = 0;
uint64_t responseBodyBytesReceived = 0;
