Title: [247116] trunk/Source/WebKit
- Revision
- 247116
- Author
- dba...@webkit.org
- Date
- 2019-07-03 16:22:46 -0700 (Wed, 03 Jul 2019)
Log Message
REGRESSION (r246817): fast/events/ios/key-events-comprehensive/key-events-{control, control-shift}.html are failing
https://bugs.webkit.org/show_bug.cgi?id=199465
<rdar://problem/52613496>
Reviewed by Wenson Hsieh.
Don't advertise that WebKit can perform cursor movements when there isn't some kind of selection.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView canPerformAction:withSender:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (247115 => 247116)
--- trunk/Source/WebKit/ChangeLog 2019-07-03 22:52:26 UTC (rev 247115)
+++ trunk/Source/WebKit/ChangeLog 2019-07-03 23:22:46 UTC (rev 247116)
@@ -1,3 +1,16 @@
+2019-07-03 Daniel Bates <daba...@apple.com>
+
+ REGRESSION (r246817): fast/events/ios/key-events-comprehensive/key-events-{control, control-shift}.html are failing
+ https://bugs.webkit.org/show_bug.cgi?id=199465
+ <rdar://problem/52613496>
+
+ Reviewed by Wenson Hsieh.
+
+ Don't advertise that WebKit can perform cursor movements when there isn't some kind of selection.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView canPerformAction:withSender:]):
+
2019-07-03 Chris Dumez <cdu...@apple.com>
Fix a couple of thread safety issues in ResourceLoadStatisticsStore
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (247115 => 247116)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2019-07-03 22:52:26 UTC (rev 247115)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2019-07-03 23:22:46 UTC (rev 247116)
@@ -2902,7 +2902,7 @@
|| action == @selector(_moveToEndOfDocument:withHistory:) || action == @selector(_moveToEndOfLine:withHistory:) || action == @selector(_moveToEndOfParagraph:withHistory:)
|| action == @selector(_moveToEndOfWord:withHistory:) || action == @selector(_moveToStartOfDocument:withHistory:) || action == @selector(_moveToStartOfLine:withHistory:)
|| action == @selector(_moveToStartOfParagraph:withHistory:) || action == @selector(_moveToStartOfWord:withHistory:) || action == @selector(_moveUp:withHistory:))
- return YES;
+ return !editorState.selectionIsNone;
if (action == @selector(_deleteByWord) || action == @selector(_deleteForwardAndNotify:) || action == @selector(_deleteToEndOfParagraph) || action == @selector(_deleteToStartOfLine)
|| action == @selector(_transpose))
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
