Title: [247203] trunk/Source/WebKit
- Revision
- 247203
- Author
- [email protected]
- Date
- 2019-07-08 01:17:24 -0700 (Mon, 08 Jul 2019)
Log Message
[GTK] ViewGestureController constructor leaves m_direction uninitialized
https://bugs.webkit.org/show_bug.cgi?id=199532
Reviewed by Carlos Garcia Campos.
This is harmless because it should never be read until after it's initialized, but still not
robust. Fix it by assuming Back as the default value until the first swipe begins.
* UIProcess/ViewGestureController.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (247202 => 247203)
--- trunk/Source/WebKit/ChangeLog 2019-07-08 05:07:19 UTC (rev 247202)
+++ trunk/Source/WebKit/ChangeLog 2019-07-08 08:17:24 UTC (rev 247203)
@@ -1,3 +1,15 @@
+2019-07-08 Michael Catanzaro <[email protected]>
+
+ [GTK] ViewGestureController constructor leaves m_direction uninitialized
+ https://bugs.webkit.org/show_bug.cgi?id=199532
+
+ Reviewed by Carlos Garcia Campos.
+
+ This is harmless because it should never be read until after it's initialized, but still not
+ robust. Fix it by assuming Back as the default value until the first swipe begins.
+
+ * UIProcess/ViewGestureController.h:
+
2019-07-07 Zalan Bujtas <[email protected]>
[ContentChangeObserver] Difficult to control videos on iqiyi.com as the actions are mouse hover
Modified: trunk/Source/WebKit/UIProcess/ViewGestureController.h (247202 => 247203)
--- trunk/Source/WebKit/UIProcess/ViewGestureController.h 2019-07-08 05:07:19 UTC (rev 247202)
+++ trunk/Source/WebKit/UIProcess/ViewGestureController.h 2019-07-08 08:17:24 UTC (rev 247203)
@@ -388,7 +388,7 @@
State m_state { State::None };
- SwipeDirection m_direction;
+ SwipeDirection m_direction { SwipeDirection::Back };
RefPtr<WebBackForwardListItem> m_targetItem;
unsigned m_tickCallbackID { 0 };
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
