Title: [247205] trunk
Revision
247205
Author
[email protected]
Date
2019-07-08 04:22:06 -0700 (Mon, 08 Jul 2019)

Log Message

[Pointer Events] Enable only on the most recent version of the supported iOS family
https://bugs.webkit.org/show_bug.cgi?id=199562
<rdar://problem/52766511>

Reviewed by Dean Jackson.

Source/_javascript_Core:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit:

* Configurations/FeatureDefines.xcconfig:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView cancelPointersForGestureRecognizer:]):
(-[WKContentView activeTouchIdentifierForGestureRecognizer:]):
(-[WKContentView touchActionActiveTouches]):
* UIProcess/ios/WKSyntheticTapGestureRecognizer.m:
(-[WKSyntheticTapGestureRecognizer touchesEnded:withEvent:]):
* UIProcess/ios/WKTouchActionGestureRecognizer.h:
* UIProcess/ios/WKTouchActionGestureRecognizer.mm:
(-[WKTouchActionGestureRecognizer canPreventGestureRecognizer:]):

Source/WebKitLegacy/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

We really don't need HAVE_UI_WEB_TOUCH_EVENTS_GESTURE_RECOGNIZER_WITH_ACTIVE_TOUCHES_BY_ID since the UIKit SPI
that was added in iOS 13 that it's checking for is really required for all parts of the implementation of Pointer
Events, including dispatch of the "pointercancel" event and support for the "touch-action" CSS property.

* wtf/Platform.h:

Tools:

* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

* js/dom/navigator-maxtouchpoints-expected.txt: Since ENABLE_POINTER_EVENTS is now disabled by default, navigator.maxTouchPoints
is "undefined" in thed default case.
* platform/mac/js/dom/navigator-maxtouchpoints-expected.txt: But 0 on macOS.

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (247204 => 247205)


--- trunk/LayoutTests/ChangeLog	2019-07-08 10:08:04 UTC (rev 247204)
+++ trunk/LayoutTests/ChangeLog	2019-07-08 11:22:06 UTC (rev 247205)
@@ -1,3 +1,15 @@
+2019-07-08  Antoine Quint  <[email protected]>
+
+        [Pointer Events] Enable only on the most recent version of the supported iOS family
+        https://bugs.webkit.org/show_bug.cgi?id=199562
+        <rdar://problem/52766511>
+
+        Reviewed by Dean Jackson.
+
+        * js/dom/navigator-maxtouchpoints-expected.txt: Since ENABLE_POINTER_EVENTS is now disabled by default, navigator.maxTouchPoints
+        is "undefined" in thed default case.
+        * platform/mac/js/dom/navigator-maxtouchpoints-expected.txt: But 0 on macOS.
+
 2019-07-07  Zalan Bujtas  <[email protected]>
 
         [ContentChangeObserver] Difficult to control videos on iqiyi.com as the actions are mouse hover

Modified: trunk/LayoutTests/js/dom/navigator-maxtouchpoints-expected.txt (247204 => 247205)


--- trunk/LayoutTests/js/dom/navigator-maxtouchpoints-expected.txt	2019-07-08 10:08:04 UTC (rev 247204)
+++ trunk/LayoutTests/js/dom/navigator-maxtouchpoints-expected.txt	2019-07-08 11:22:06 UTC (rev 247205)
@@ -3,7 +3,7 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-navigator.maxTouchPoints = 0
+navigator.maxTouchPoints = undefined
 PASS successfullyParsed is true
 
 TEST COMPLETE

Copied: trunk/LayoutTests/platform/mac/js/dom/navigator-maxtouchpoints-expected.txt (from rev 247204, trunk/LayoutTests/js/dom/navigator-maxtouchpoints-expected.txt) (0 => 247205)


--- trunk/LayoutTests/platform/mac/js/dom/navigator-maxtouchpoints-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/platform/mac/js/dom/navigator-maxtouchpoints-expected.txt	2019-07-08 11:22:06 UTC (rev 247205)
@@ -0,0 +1,10 @@
+Check return value of navigator.maxTouchPoints.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+navigator.maxTouchPoints = 0
+PASS successfullyParsed is true
+
+TEST COMPLETE
+

Modified: trunk/Source/_javascript_Core/ChangeLog (247204 => 247205)


--- trunk/Source/_javascript_Core/ChangeLog	2019-07-08 10:08:04 UTC (rev 247204)
+++ trunk/Source/_javascript_Core/ChangeLog	2019-07-08 11:22:06 UTC (rev 247205)
@@ -1,3 +1,13 @@
+2019-07-08  Antoine Quint  <[email protected]>
+
+        [Pointer Events] Enable only on the most recent version of the supported iOS family
+        https://bugs.webkit.org/show_bug.cgi?id=199562
+        <rdar://problem/52766511>
+
+        Reviewed by Dean Jackson.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2019-07-06  Michael Saboff  <[email protected]>
 
         switch(String) needs to check for exceptions when resolving the string

Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (247204 => 247205)


--- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2019-07-08 10:08:04 UTC (rev 247204)
+++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2019-07-08 11:22:06 UTC (rev 247205)
@@ -316,8 +316,9 @@
 ENABLE_PDFKIT_PLUGIN_macosx = ENABLE_PDFKIT_PLUGIN;
 
 ENABLE_POINTER_EVENTS = $(ENABLE_POINTER_EVENTS_$(WK_PLATFORM_NAME));
-ENABLE_POINTER_EVENTS_iphoneos = ENABLE_POINTER_EVENTS;
-ENABLE_POINTER_EVENTS_iphonesimulator = ENABLE_POINTER_EVENTS;
+ENABLE_POINTER_EVENTS_iphoneos = $(ENABLE_POINTER_EVENTS$(WK_IOS_13));
+ENABLE_POINTER_EVENTS_iphonesimulator = $(ENABLE_POINTER_EVENTS$(WK_IOS_13));
+ENABLE_POINTER_EVENTS_IOS_SINCE_13 = ENABLE_POINTER_EVENTS;
 ENABLE_POINTER_EVENTS_maccatalyst = ENABLE_POINTER_EVENTS;
 ENABLE_POINTER_EVENTS_macosx = ENABLE_POINTER_EVENTS;
 ENABLE_POINTER_EVENTS_watchos = ENABLE_POINTER_EVENTS;

Modified: trunk/Source/WTF/ChangeLog (247204 => 247205)


--- trunk/Source/WTF/ChangeLog	2019-07-08 10:08:04 UTC (rev 247204)
+++ trunk/Source/WTF/ChangeLog	2019-07-08 11:22:06 UTC (rev 247205)
@@ -1,3 +1,17 @@
+2019-07-08  Antoine Quint  <[email protected]>
+
+        [Pointer Events] Enable only on the most recent version of the supported iOS family
+        https://bugs.webkit.org/show_bug.cgi?id=199562
+        <rdar://problem/52766511>
+
+        Reviewed by Dean Jackson.
+
+        We really don't need HAVE_UI_WEB_TOUCH_EVENTS_GESTURE_RECOGNIZER_WITH_ACTIVE_TOUCHES_BY_ID since the UIKit SPI
+        that was added in iOS 13 that it's checking for is really required for all parts of the implementation of Pointer
+        Events, including dispatch of the "pointercancel" event and support for the "touch-action" CSS property.
+
+        * wtf/Platform.h:
+
 2019-07-05  Ryan Haddad  <[email protected]>
 
         Unreviewed, rolling out r247115.

Modified: trunk/Source/WTF/wtf/Platform.h (247204 => 247205)


--- trunk/Source/WTF/wtf/Platform.h	2019-07-08 10:08:04 UTC (rev 247204)
+++ trunk/Source/WTF/wtf/Platform.h	2019-07-08 11:22:06 UTC (rev 247205)
@@ -1534,10 +1534,6 @@
 #endif
 
 #if PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000
-#define HAVE_UI_WEB_TOUCH_EVENTS_GESTURE_RECOGNIZER_WITH_ACTIVE_TOUCHES_BY_ID 1
-#endif
-
-#if PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000
 #define HAVE_ARKIT_QUICK_LOOK_PREVIEW_ITEM 1
 #endif
 

Modified: trunk/Source/WebCore/ChangeLog (247204 => 247205)


--- trunk/Source/WebCore/ChangeLog	2019-07-08 10:08:04 UTC (rev 247204)
+++ trunk/Source/WebCore/ChangeLog	2019-07-08 11:22:06 UTC (rev 247205)
@@ -1,3 +1,13 @@
+2019-07-08  Antoine Quint  <[email protected]>
+
+        [Pointer Events] Enable only on the most recent version of the supported iOS family
+        https://bugs.webkit.org/show_bug.cgi?id=199562
+        <rdar://problem/52766511>
+
+        Reviewed by Dean Jackson.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2019-07-08  Philippe Normand  <[email protected]>
 
         [GStreamer] The CREATE_TRACK macro is messed up

Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (247204 => 247205)


--- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2019-07-08 10:08:04 UTC (rev 247204)
+++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2019-07-08 11:22:06 UTC (rev 247205)
@@ -316,8 +316,9 @@
 ENABLE_PDFKIT_PLUGIN_macosx = ENABLE_PDFKIT_PLUGIN;
 
 ENABLE_POINTER_EVENTS = $(ENABLE_POINTER_EVENTS_$(WK_PLATFORM_NAME));
-ENABLE_POINTER_EVENTS_iphoneos = ENABLE_POINTER_EVENTS;
-ENABLE_POINTER_EVENTS_iphonesimulator = ENABLE_POINTER_EVENTS;
+ENABLE_POINTER_EVENTS_iphoneos = $(ENABLE_POINTER_EVENTS$(WK_IOS_13));
+ENABLE_POINTER_EVENTS_iphonesimulator = $(ENABLE_POINTER_EVENTS$(WK_IOS_13));
+ENABLE_POINTER_EVENTS_IOS_SINCE_13 = ENABLE_POINTER_EVENTS;
 ENABLE_POINTER_EVENTS_maccatalyst = ENABLE_POINTER_EVENTS;
 ENABLE_POINTER_EVENTS_macosx = ENABLE_POINTER_EVENTS;
 ENABLE_POINTER_EVENTS_watchos = ENABLE_POINTER_EVENTS;

Modified: trunk/Source/WebCore/PAL/ChangeLog (247204 => 247205)


--- trunk/Source/WebCore/PAL/ChangeLog	2019-07-08 10:08:04 UTC (rev 247204)
+++ trunk/Source/WebCore/PAL/ChangeLog	2019-07-08 11:22:06 UTC (rev 247205)
@@ -1,3 +1,13 @@
+2019-07-08  Antoine Quint  <[email protected]>
+
+        [Pointer Events] Enable only on the most recent version of the supported iOS family
+        https://bugs.webkit.org/show_bug.cgi?id=199562
+        <rdar://problem/52766511>
+
+        Reviewed by Dean Jackson.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2019-07-05  Ryan Haddad  <[email protected]>
 
         Unreviewed, rolling out r247159.

Modified: trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig (247204 => 247205)


--- trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig	2019-07-08 10:08:04 UTC (rev 247204)
+++ trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig	2019-07-08 11:22:06 UTC (rev 247205)
@@ -316,8 +316,9 @@
 ENABLE_PDFKIT_PLUGIN_macosx = ENABLE_PDFKIT_PLUGIN;
 
 ENABLE_POINTER_EVENTS = $(ENABLE_POINTER_EVENTS_$(WK_PLATFORM_NAME));
-ENABLE_POINTER_EVENTS_iphoneos = ENABLE_POINTER_EVENTS;
-ENABLE_POINTER_EVENTS_iphonesimulator = ENABLE_POINTER_EVENTS;
+ENABLE_POINTER_EVENTS_iphoneos = $(ENABLE_POINTER_EVENTS$(WK_IOS_13));
+ENABLE_POINTER_EVENTS_iphonesimulator = $(ENABLE_POINTER_EVENTS$(WK_IOS_13));
+ENABLE_POINTER_EVENTS_IOS_SINCE_13 = ENABLE_POINTER_EVENTS;
 ENABLE_POINTER_EVENTS_maccatalyst = ENABLE_POINTER_EVENTS;
 ENABLE_POINTER_EVENTS_macosx = ENABLE_POINTER_EVENTS;
 ENABLE_POINTER_EVENTS_watchos = ENABLE_POINTER_EVENTS;

Modified: trunk/Source/WebKit/ChangeLog (247204 => 247205)


--- trunk/Source/WebKit/ChangeLog	2019-07-08 10:08:04 UTC (rev 247204)
+++ trunk/Source/WebKit/ChangeLog	2019-07-08 11:22:06 UTC (rev 247205)
@@ -1,3 +1,22 @@
+2019-07-08  Antoine Quint  <[email protected]>
+
+        [Pointer Events] Enable only on the most recent version of the supported iOS family
+        https://bugs.webkit.org/show_bug.cgi?id=199562
+        <rdar://problem/52766511>
+
+        Reviewed by Dean Jackson.
+
+        * Configurations/FeatureDefines.xcconfig:
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (-[WKContentView cancelPointersForGestureRecognizer:]):
+        (-[WKContentView activeTouchIdentifierForGestureRecognizer:]):
+        (-[WKContentView touchActionActiveTouches]):
+        * UIProcess/ios/WKSyntheticTapGestureRecognizer.m:
+        (-[WKSyntheticTapGestureRecognizer touchesEnded:withEvent:]):
+        * UIProcess/ios/WKTouchActionGestureRecognizer.h:
+        * UIProcess/ios/WKTouchActionGestureRecognizer.mm:
+        (-[WKTouchActionGestureRecognizer canPreventGestureRecognizer:]):
+
 2019-07-08  Michael Catanzaro  <[email protected]>
 
         [GTK] ViewGestureController constructor leaves m_direction uninitialized

Modified: trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig (247204 => 247205)


--- trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig	2019-07-08 10:08:04 UTC (rev 247204)
+++ trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig	2019-07-08 11:22:06 UTC (rev 247205)
@@ -316,8 +316,9 @@
 ENABLE_PDFKIT_PLUGIN_macosx = ENABLE_PDFKIT_PLUGIN;
 
 ENABLE_POINTER_EVENTS = $(ENABLE_POINTER_EVENTS_$(WK_PLATFORM_NAME));
-ENABLE_POINTER_EVENTS_iphoneos = ENABLE_POINTER_EVENTS;
-ENABLE_POINTER_EVENTS_iphonesimulator = ENABLE_POINTER_EVENTS;
+ENABLE_POINTER_EVENTS_iphoneos = $(ENABLE_POINTER_EVENTS$(WK_IOS_13));
+ENABLE_POINTER_EVENTS_iphonesimulator = $(ENABLE_POINTER_EVENTS$(WK_IOS_13));
+ENABLE_POINTER_EVENTS_IOS_SINCE_13 = ENABLE_POINTER_EVENTS;
 ENABLE_POINTER_EVENTS_maccatalyst = ENABLE_POINTER_EVENTS;
 ENABLE_POINTER_EVENTS_macosx = ENABLE_POINTER_EVENTS;
 ENABLE_POINTER_EVENTS_watchos = ENABLE_POINTER_EVENTS;

Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (247204 => 247205)


--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2019-07-08 10:08:04 UTC (rev 247204)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2019-07-08 11:22:06 UTC (rev 247205)
@@ -1287,8 +1287,6 @@
 #if ENABLE(POINTER_EVENTS)
 - (void)cancelPointersForGestureRecognizer:(UIGestureRecognizer *)gestureRecognizer
 {
-#if HAVE(UI_WEB_TOUCH_EVENTS_GESTURE_RECOGNIZER_WITH_ACTIVE_TOUCHES_BY_ID)
-    // FIXME: <rdar://problem/48035706>
     NSMapTable<NSNumber *, UITouch *> *activeTouches = [_touchEventGestureRecognizer activeTouchesByIdentifier];
     for (NSNumber *touchIdentifier in activeTouches) {
         UITouch *touch = [activeTouches objectForKey:touchIdentifier];
@@ -1295,13 +1293,10 @@
         if ([touch.gestureRecognizers containsObject:gestureRecognizer])
             _page->cancelPointer([touchIdentifier unsignedIntValue], WebCore::roundedIntPoint([touch locationInView:self]));
     }
-#endif
 }
 
 - (WTF::Optional<unsigned>)activeTouchIdentifierForGestureRecognizer:(UIGestureRecognizer *)gestureRecognizer
 {
-#if HAVE(UI_WEB_TOUCH_EVENTS_GESTURE_RECOGNIZER_WITH_ACTIVE_TOUCHES_BY_ID)
-    // FIXME: <rdar://problem/48035706>
     NSMapTable<NSNumber *, UITouch *> *activeTouches = [_touchEventGestureRecognizer activeTouchesByIdentifier];
     for (NSNumber *touchIdentifier in activeTouches) {
         UITouch *touch = [activeTouches objectForKey:touchIdentifier];
@@ -1308,7 +1303,6 @@
         if ([touch.gestureRecognizers containsObject:gestureRecognizer])
             return [touchIdentifier unsignedIntValue];
     }
-#endif
     return WTF::nullopt;
 }
 #endif
@@ -1399,12 +1393,10 @@
     return gestureRecognizer == [_webView scrollView].pinchGestureRecognizer;
 }
 
-#if HAVE(UI_WEB_TOUCH_EVENTS_GESTURE_RECOGNIZER_WITH_ACTIVE_TOUCHES_BY_ID)
 - (NSMapTable<NSNumber *, UITouch *> *)touchActionActiveTouches
 {
     return [_touchEventGestureRecognizer activeTouchesByIdentifier];
 }
-#endif
 
 - (void)_resetPanningPreventionFlags
 {

Modified: trunk/Source/WebKit/UIProcess/ios/WKSyntheticTapGestureRecognizer.m (247204 => 247205)


--- trunk/Source/WebKit/UIProcess/ios/WKSyntheticTapGestureRecognizer.m	2019-07-08 10:08:04 UTC (rev 247204)
+++ trunk/Source/WebKit/UIProcess/ios/WKSyntheticTapGestureRecognizer.m	2019-07-08 11:22:06 UTC (rev 247205)
@@ -78,7 +78,7 @@
 - (void)touchesEnded:(NSSet<UITouch *> *)touches withEvent:(UIEvent *)event
 {
     [super touchesEnded:touches withEvent:event];
-#if ENABLE(POINTER_EVENTS) && HAVE(UI_WEB_TOUCH_EVENTS_GESTURE_RECOGNIZER_WITH_ACTIVE_TOUCHES_BY_ID)
+#if ENABLE(POINTER_EVENTS)
     if (!_supportingWebTouchEventsGestureRecognizer)
         return;
 

Modified: trunk/Source/WebKit/UIProcess/ios/WKTouchActionGestureRecognizer.h (247204 => 247205)


--- trunk/Source/WebKit/UIProcess/ios/WKTouchActionGestureRecognizer.h	2019-07-08 10:08:04 UTC (rev 247204)
+++ trunk/Source/WebKit/UIProcess/ios/WKTouchActionGestureRecognizer.h	2019-07-08 11:22:06 UTC (rev 247205)
@@ -39,9 +39,7 @@
 
 @protocol WKTouchActionGestureRecognizerDelegate <NSObject>
 - (BOOL)gestureRecognizerMayPinchToZoomWebView:(UIGestureRecognizer *)gestureRecognizer;
-#if HAVE(UI_WEB_TOUCH_EVENTS_GESTURE_RECOGNIZER_WITH_ACTIVE_TOUCHES_BY_ID)
 - (NSMapTable<NSNumber *, UITouch *> *)touchActionActiveTouches;
-#endif
 @end
 
 #endif

Modified: trunk/Source/WebKit/UIProcess/ios/WKTouchActionGestureRecognizer.mm (247204 => 247205)


--- trunk/Source/WebKit/UIProcess/ios/WKTouchActionGestureRecognizer.mm	2019-07-08 10:08:04 UTC (rev 247204)
+++ trunk/Source/WebKit/UIProcess/ios/WKTouchActionGestureRecognizer.mm	2019-07-08 11:22:06 UTC (rev 247205)
@@ -86,7 +86,6 @@
     return NO;
 }
 
-#if HAVE(UI_WEB_TOUCH_EVENTS_GESTURE_RECOGNIZER_WITH_ACTIVE_TOUCHES_BY_ID)
 - (BOOL)canPreventGestureRecognizer:(UIGestureRecognizer *)preventedGestureRecognizer
 {
     if (_touchActionsByTouchIdentifier.isEmpty())
@@ -111,7 +110,6 @@
 
     return NO;
 }
-#endif
 
 @end
 

Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (247204 => 247205)


--- trunk/Source/WebKitLegacy/mac/ChangeLog	2019-07-08 10:08:04 UTC (rev 247204)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2019-07-08 11:22:06 UTC (rev 247205)
@@ -1,3 +1,13 @@
+2019-07-08  Antoine Quint  <[email protected]>
+
+        [Pointer Events] Enable only on the most recent version of the supported iOS family
+        https://bugs.webkit.org/show_bug.cgi?id=199562
+        <rdar://problem/52766511>
+
+        Reviewed by Dean Jackson.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2019-07-03  Sam Weinig  <[email protected]>
 
         Adopt simple structured bindings in more places

Modified: trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig (247204 => 247205)


--- trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig	2019-07-08 10:08:04 UTC (rev 247204)
+++ trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig	2019-07-08 11:22:06 UTC (rev 247205)
@@ -316,8 +316,9 @@
 ENABLE_PDFKIT_PLUGIN_macosx = ENABLE_PDFKIT_PLUGIN;
 
 ENABLE_POINTER_EVENTS = $(ENABLE_POINTER_EVENTS_$(WK_PLATFORM_NAME));
-ENABLE_POINTER_EVENTS_iphoneos = ENABLE_POINTER_EVENTS;
-ENABLE_POINTER_EVENTS_iphonesimulator = ENABLE_POINTER_EVENTS;
+ENABLE_POINTER_EVENTS_iphoneos = $(ENABLE_POINTER_EVENTS$(WK_IOS_13));
+ENABLE_POINTER_EVENTS_iphonesimulator = $(ENABLE_POINTER_EVENTS$(WK_IOS_13));
+ENABLE_POINTER_EVENTS_IOS_SINCE_13 = ENABLE_POINTER_EVENTS;
 ENABLE_POINTER_EVENTS_maccatalyst = ENABLE_POINTER_EVENTS;
 ENABLE_POINTER_EVENTS_macosx = ENABLE_POINTER_EVENTS;
 ENABLE_POINTER_EVENTS_watchos = ENABLE_POINTER_EVENTS;

Modified: trunk/Tools/ChangeLog (247204 => 247205)


--- trunk/Tools/ChangeLog	2019-07-08 10:08:04 UTC (rev 247204)
+++ trunk/Tools/ChangeLog	2019-07-08 11:22:06 UTC (rev 247205)
@@ -1,3 +1,13 @@
+2019-07-08  Antoine Quint  <[email protected]>
+
+        [Pointer Events] Enable only on the most recent version of the supported iOS family
+        https://bugs.webkit.org/show_bug.cgi?id=199562
+        <rdar://problem/52766511>
+
+        Reviewed by Dean Jackson.
+
+        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+
 2019-07-06  Simon Fraser  <[email protected]>
 
         Long hang when loading a cnn.com page on iOS

Modified: trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig (247204 => 247205)


--- trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig	2019-07-08 10:08:04 UTC (rev 247204)
+++ trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig	2019-07-08 11:22:06 UTC (rev 247205)
@@ -316,8 +316,9 @@
 ENABLE_PDFKIT_PLUGIN_macosx = ENABLE_PDFKIT_PLUGIN;
 
 ENABLE_POINTER_EVENTS = $(ENABLE_POINTER_EVENTS_$(WK_PLATFORM_NAME));
-ENABLE_POINTER_EVENTS_iphoneos = ENABLE_POINTER_EVENTS;
-ENABLE_POINTER_EVENTS_iphonesimulator = ENABLE_POINTER_EVENTS;
+ENABLE_POINTER_EVENTS_iphoneos = $(ENABLE_POINTER_EVENTS$(WK_IOS_13));
+ENABLE_POINTER_EVENTS_iphonesimulator = $(ENABLE_POINTER_EVENTS$(WK_IOS_13));
+ENABLE_POINTER_EVENTS_IOS_SINCE_13 = ENABLE_POINTER_EVENTS;
 ENABLE_POINTER_EVENTS_maccatalyst = ENABLE_POINTER_EVENTS;
 ENABLE_POINTER_EVENTS_macosx = ENABLE_POINTER_EVENTS;
 ENABLE_POINTER_EVENTS_watchos = ENABLE_POINTER_EVENTS;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to