Title: [247209] trunk/Source/WebKit
- Revision
- 247209
- Author
- [email protected]
- Date
- 2019-07-08 09:40:02 -0700 (Mon, 08 Jul 2019)
Log Message
REGRESSION(r246671): [WPE][GTK] Crash in NetworkProcess since the DNS cache landed
https://bugs.webkit.org/show_bug.cgi?id=199572
Reviewed by Michael Catanzaro.
The GError coming from the wrapped resolver shouldn't be freed,
but passed onto the caller.
* NetworkProcess/glib/WebKitCachedResolver.cpp:
(webkitCachedResolverLookupByNameAsync):
(webkitCachedResolverLookupByNameWithFlagsAsync):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (247208 => 247209)
--- trunk/Source/WebKit/ChangeLog 2019-07-08 16:25:55 UTC (rev 247208)
+++ trunk/Source/WebKit/ChangeLog 2019-07-08 16:40:02 UTC (rev 247209)
@@ -1,3 +1,17 @@
+2019-07-08 Claudio Saavedra <[email protected]>
+
+ REGRESSION(r246671): [WPE][GTK] Crash in NetworkProcess since the DNS cache landed
+ https://bugs.webkit.org/show_bug.cgi?id=199572
+
+ Reviewed by Michael Catanzaro.
+
+ The GError coming from the wrapped resolver shouldn't be freed,
+ but passed onto the caller.
+
+ * NetworkProcess/glib/WebKitCachedResolver.cpp:
+ (webkitCachedResolverLookupByNameAsync):
+ (webkitCachedResolverLookupByNameWithFlagsAsync):
+
2019-07-07 Antoine Quint <[email protected]>
[Pointer Events] touch-action should affect the behavior of pinch-to-zoom to show tabs in Safari
Modified: trunk/Source/WebKit/NetworkProcess/glib/WebKitCachedResolver.cpp (247208 => 247209)
--- trunk/Source/WebKit/NetworkProcess/glib/WebKitCachedResolver.cpp 2019-07-08 16:25:55 UTC (rev 247208)
+++ trunk/Source/WebKit/NetworkProcess/glib/WebKitCachedResolver.cpp 2019-07-08 16:40:02 UTC (rev 247209)
@@ -108,7 +108,7 @@
priv->cache.update(asyncData->hostname, addressListGListToVector(addressList));
g_task_return_pointer(task.get(), addressList, reinterpret_cast<GDestroyNotify>(g_resolver_free_addresses));
} else
- g_task_return_error(task.get(), error.get());
+ g_task_return_error(task.get(), error.release().release());
}, task.leakRef());
}
@@ -170,7 +170,7 @@
priv->cache.update(asyncData->hostname, addressListGListToVector(addressList), asyncData->dnsCacheType);
g_task_return_pointer(task.get(), addressList, reinterpret_cast<GDestroyNotify>(g_resolver_free_addresses));
} else
- g_task_return_error(task.get(), error.get());
+ g_task_return_error(task.get(), error.release().release());
}, task.leakRef());
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
