Title: [247213] trunk
- Revision
- 247213
- Author
- [email protected]
- Date
- 2019-07-08 11:14:21 -0700 (Mon, 08 Jul 2019)
Log Message
Unable to play videos on xfinity.com/stream on macOS Catalina
https://bugs.webkit.org/show_bug.cgi?id=199576
<rdar://problem/50101264>
Reviewed by Alex Christensen.
Source/WebCore:
Enable invalidate Fetch signal quirk for all sites as the blacklist is getting too large and
we are finding too much breakage too late in the release cycle.
* Modules/fetch/FetchRequest.cpp:
(WebCore::processInvalidSignal):
* page/Quirks.cpp:
(WebCore::Quirks::shouldIgnoreInvalidSignal const):
LayoutTests:
Rebaseline existing test.
* http/wpt/fetch/request-abort-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (247212 => 247213)
--- trunk/LayoutTests/ChangeLog 2019-07-08 18:00:33 UTC (rev 247212)
+++ trunk/LayoutTests/ChangeLog 2019-07-08 18:14:21 UTC (rev 247213)
@@ -1,3 +1,15 @@
+2019-07-08 Chris Dumez <[email protected]>
+
+ Unable to play videos on xfinity.com/stream on macOS Catalina
+ https://bugs.webkit.org/show_bug.cgi?id=199576
+ <rdar://problem/50101264>
+
+ Reviewed by Alex Christensen.
+
+ Rebaseline existing test.
+
+ * http/wpt/fetch/request-abort-expected.txt:
+
2019-07-08 Antoine Quint <[email protected]>
[Pointer Events] "touch-action: none" does not prevent double-tap-to-zoom
Modified: trunk/LayoutTests/http/wpt/fetch/request-abort-expected.txt (247212 => 247213)
--- trunk/LayoutTests/http/wpt/fetch/request-abort-expected.txt 2019-07-08 18:00:33 UTC (rev 247212)
+++ trunk/LayoutTests/http/wpt/fetch/request-abort-expected.txt 2019-07-08 18:14:21 UTC (rev 247213)
@@ -1,5 +1,5 @@
-CONSOLE MESSAGE: line 14: FetchRequestInit.signal should be undefined, null or an AbortSignal object.
-CONSOLE MESSAGE: line 28: FetchRequestInit.signal should be undefined, null or an AbortSignal object.
+CONSOLE MESSAGE: line 14: FetchRequestInit.signal should be undefined, null or an AbortSignal object. This will throw in a future release.
+CONSOLE MESSAGE: line 28: FetchRequestInit.signal should be undefined, null or an AbortSignal object. This will throw in a future release.
PASS Request from URL with signal
PASS Request from request with signal
Modified: trunk/Source/WebCore/ChangeLog (247212 => 247213)
--- trunk/Source/WebCore/ChangeLog 2019-07-08 18:00:33 UTC (rev 247212)
+++ trunk/Source/WebCore/ChangeLog 2019-07-08 18:14:21 UTC (rev 247213)
@@ -1,3 +1,19 @@
+2019-07-08 Chris Dumez <[email protected]>
+
+ Unable to play videos on xfinity.com/stream on macOS Catalina
+ https://bugs.webkit.org/show_bug.cgi?id=199576
+ <rdar://problem/50101264>
+
+ Reviewed by Alex Christensen.
+
+ Enable invalidate Fetch signal quirk for all sites as the blacklist is getting too large and
+ we are finding too much breakage too late in the release cycle.
+
+ * Modules/fetch/FetchRequest.cpp:
+ (WebCore::processInvalidSignal):
+ * page/Quirks.cpp:
+ (WebCore::Quirks::shouldIgnoreInvalidSignal const):
+
2019-07-08 Youenn Fablet <[email protected]>
MediaStreamTrackPrivate should always call readyStateChanged on the main thread
Modified: trunk/Source/WebCore/Modules/fetch/FetchRequest.cpp (247212 => 247213)
--- trunk/Source/WebCore/Modules/fetch/FetchRequest.cpp 2019-07-08 18:00:33 UTC (rev 247212)
+++ trunk/Source/WebCore/Modules/fetch/FetchRequest.cpp 2019-07-08 18:14:21 UTC (rev 247213)
@@ -147,7 +147,7 @@
static inline Optional<Exception> processInvalidSignal(ScriptExecutionContext& context)
{
- ASCIILiteral message { "FetchRequestInit.signal should be undefined, null or an AbortSignal object."_s };
+ ASCIILiteral message { "FetchRequestInit.signal should be undefined, null or an AbortSignal object. This will throw in a future release."_s };
context.addConsoleMessage(MessageSource::JS, MessageLevel::Warning, message);
if (is<Document>(context) && downcast<Document>(context).quirks().shouldIgnoreInvalidSignal())
Modified: trunk/Source/WebCore/page/Quirks.cpp (247212 => 247213)
--- trunk/Source/WebCore/page/Quirks.cpp 2019-07-08 18:00:33 UTC (rev 247212)
+++ trunk/Source/WebCore/page/Quirks.cpp 2019-07-08 18:14:21 UTC (rev 247213)
@@ -90,13 +90,7 @@
bool Quirks::shouldIgnoreInvalidSignal() const
{
- if (!needsQuirks())
- return false;
-
- auto host = m_document->topDocument().url().host();
- return equalLettersIgnoringASCIICase(host, "www.thrivepatientportal.com")
- || equalLettersIgnoringASCIICase(host, "www.bnz.co.nz")
- || equalLettersIgnoringASCIICase(host, "www.carvana.com");
+ return needsQuirks();
}
bool Quirks::needsFormControlToBeMouseFocusable() const
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
