Title: [247235] trunk/Source/WebInspectorUI
- Revision
- 247235
- Author
- drou...@apple.com
- Date
- 2019-07-08 16:34:19 -0700 (Mon, 08 Jul 2019)
Log Message
Web Inspector: Timelines: CPU: the Duration string isn't localized
https://bugs.webkit.org/show_bug.cgi?id=199582
<rdar://problem/51698165>
Reviewed by Joseph Pecoraro.
* UserInterface/Views/CPUTimelineView.js:
(WI.CPUTimelineView.prototype._layoutEnergyChart):
* Localizations/en.lproj/localizedStrings.js:
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (247234 => 247235)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-07-08 23:31:25 UTC (rev 247234)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-07-08 23:34:19 UTC (rev 247235)
@@ -1,3 +1,16 @@
+2019-07-08 Devin Rousso <drou...@apple.com>
+
+ Web Inspector: Timelines: CPU: the Duration string isn't localized
+ https://bugs.webkit.org/show_bug.cgi?id=199582
+ <rdar://problem/51698165>
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/CPUTimelineView.js:
+ (WI.CPUTimelineView.prototype._layoutEnergyChart):
+
+ * Localizations/en.lproj/localizedStrings.js:
+
2019-07-06 Nikita Vasilyev <nvasil...@apple.com>
Web Inspector: Styles: unbalanced quotes and parenthesis aren't displayed as property closed after editing values
Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (247234 => 247235)
--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2019-07-08 23:31:25 UTC (rev 247234)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2019-07-08 23:34:19 UTC (rev 247235)
@@ -361,7 +361,9 @@
localizedStrings["Dropped Node"] = "Dropped Node";
localizedStrings["Duplicate property"] = "Duplicate property";
localizedStrings["Duration"] = "Duration";
-localizedStrings["Duration: %s"] = "Duration: %s";
+/* The duration of the Timeline recording in seconds (s). */
+localizedStrings["Duration: %ss"] = "Duration: %ss";
+localizedStrings["Duration: Short"] = "Duration: Short";
localizedStrings["Dynamically calculated for the parent element"] = "Dynamically calculated for the parent element";
localizedStrings["Dynamically calculated for the selected element"] = "Dynamically calculated for the selected element";
localizedStrings["Dynamically calculated for the selected element and did not match"] = "Dynamically calculated for the selected element and did not match";
@@ -962,7 +964,6 @@
localizedStrings["Shadow Content"] = "Shadow Content";
localizedStrings["Shadow Content (%s)"] = "Shadow Content (%s)";
localizedStrings["Shared Focus"] = "Shared Focus";
-localizedStrings["Short"] = "Short";
localizedStrings["Shortest property path to %s"] = "Shortest property path to %s";
localizedStrings["Show %d More"] = "Show %d More";
localizedStrings["Show All"] = "Show All";
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js (247234 => 247235)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js 2019-07-08 23:31:25 UTC (rev 247234)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js 2019-07-08 23:34:19 UTC (rev 247235)
@@ -1136,10 +1136,10 @@
this._energyImpactNumberElement.textContent = WI.UIString("Average CPU: %s").format(Number.percentageString(average / 100));
if (visibleDuration < 5)
- this._energyImpactDurationElement.textContent = WI.UIString("Duration: %s").format(WI.UIString("Short"));
+ this._energyImpactDurationElement.textContent = WI.UIString("Duration: Short");
else {
- let durationDisplayString = Math.floor(visibleDuration) + "s";
- this._energyImpactDurationElement.textContent = WI.UIString("Duration: %s").format(durationDisplayString);
+ let durationDisplayString = Math.floor(visibleDuration);
+ this._energyImpactDurationElement.textContent = WI.UIString("Duration: %ss", "The duration of the Timeline recording in seconds (s).").format(durationDisplayString);
}
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
