Title: [247915] trunk/Source/WebCore
- Revision
- 247915
- Author
- [email protected]
- Date
- 2019-07-29 12:20:17 -0700 (Mon, 29 Jul 2019)
Log Message
Force Reveal to always lookup from menu
https://bugs.webkit.org/show_bug.cgi?id=200186
<rdar://problem/52967940>
Reviewed by Tim Horton.
We currently only have the 'lookup' menu item, so we should always force the 'lookup' action from it.
Reveal is not currently testable.
* editing/cocoa/DictionaryLookup.mm:
(WebCore::showPopupOrCreateAnimationController):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (247914 => 247915)
--- trunk/Source/WebCore/ChangeLog 2019-07-29 19:12:40 UTC (rev 247914)
+++ trunk/Source/WebCore/ChangeLog 2019-07-29 19:20:17 UTC (rev 247915)
@@ -1,3 +1,18 @@
+2019-07-29 Megan Gardner <[email protected]>
+
+ Force Reveal to always lookup from menu
+ https://bugs.webkit.org/show_bug.cgi?id=200186
+ <rdar://problem/52967940>
+
+ Reviewed by Tim Horton.
+
+ We currently only have the 'lookup' menu item, so we should always force the 'lookup' action from it.
+
+ Reveal is not currently testable.
+
+ * editing/cocoa/DictionaryLookup.mm:
+ (WebCore::showPopupOrCreateAnimationController):
+
2019-07-29 Simon Fraser <[email protected]>
REGRESSION (r246899): Subtitles show twice when controls show/hide on hulu.com
Modified: trunk/Source/WebCore/editing/cocoa/DictionaryLookup.mm (247914 => 247915)
--- trunk/Source/WebCore/editing/cocoa/DictionaryLookup.mm 2019-07-29 19:12:40 UTC (rev 247914)
+++ trunk/Source/WebCore/editing/cocoa/DictionaryLookup.mm 2019-07-29 19:20:17 UTC (rev 247915)
@@ -491,7 +491,7 @@
if (createAnimationController)
return [presenter animationControllerForItem:item.get() documentContext:nil presentingContext:context.get() options:nil];
- [presenter revealItem:item.get() documentContext:nil presentingContext:context.get() options:nil];
+ [presenter revealItem:item.get() documentContext:nil presentingContext:context.get() options:@{ @"forceLookup": @YES }];
return nil;
#elif PLATFORM(MACCATALYST)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
