Title: [102825] trunk/Source/WebCore
Revision
102825
Author
[email protected]
Date
2011-12-14 14:19:58 -0800 (Wed, 14 Dec 2011)

Log Message

Remove added calls to CSSStyleSelector to gain back another 2% in page cyclers
https://bugs.webkit.org/show_bug.cgi?id=74537

Reviewed by Ojan Vafai.

In r102234, calls to initForRegionStyling() were added in CSSStyleSelector.
There's still a 2% perf regression in chromium page cyclers, so try removing
these calls.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (102824 => 102825)


--- trunk/Source/WebCore/ChangeLog	2011-12-14 22:13:24 UTC (rev 102824)
+++ trunk/Source/WebCore/ChangeLog	2011-12-14 22:19:58 UTC (rev 102825)
@@ -1,3 +1,18 @@
+2011-12-14  Tony Chang  <[email protected]>
+
+        Remove added calls to CSSStyleSelector to gain back another 2% in page cyclers
+        https://bugs.webkit.org/show_bug.cgi?id=74537
+
+        Reviewed by Ojan Vafai.
+
+        In r102234, calls to initForRegionStyling() were added in CSSStyleSelector.
+        There's still a 2% perf regression in chromium page cyclers, so try removing
+        these calls.
+
+        * css/CSSStyleSelector.cpp:
+        (WebCore::CSSStyleSelector::styleForElement):
+        (WebCore::CSSStyleSelector::pseudoStyleForElement):
+
 2011-12-14  Jonathan Backer  <[email protected]>
 
         [chromium] Plumb through flag for enabling partial swap

Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (102824 => 102825)


--- trunk/Source/WebCore/css/CSSStyleSelector.cpp	2011-12-14 22:13:24 UTC (rev 102824)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp	2011-12-14 22:19:58 UTC (rev 102825)
@@ -1267,7 +1267,6 @@
 
     initElement(element);
     initForStyleResolve(element, defaultParent);
-    initForRegionStyling(regionForStyling);
     if (allowSharing) {
         RenderStyle* sharedStyle = locateSharedStyle();
         if (sharedStyle)
@@ -1431,7 +1430,6 @@
     initElement(e);
 
     initForStyleResolve(e, parentStyle, pseudo);
-    initForRegionStyling(regionForStyling);
     m_style = RenderStyle::create();
 
     if (m_parentStyle)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to