Title: [248059] branches/safari-608-branch/Source/WebCore
- Revision
- 248059
- Author
- [email protected]
- Date
- 2019-07-31 13:56:20 -0700 (Wed, 31 Jul 2019)
Log Message
Cherry-pick r247915. rdar://problem/53764061
Force Reveal to always lookup from menu
https://bugs.webkit.org/show_bug.cgi?id=200186
<rdar://problem/52967940>
Reviewed by Tim Horton.
We currently only have the 'lookup' menu item, so we should always force the 'lookup' action from it.
Reveal is not currently testable.
* editing/cocoa/DictionaryLookup.mm:
(WebCore::showPopupOrCreateAnimationController):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247915 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-608-branch/Source/WebCore/ChangeLog (248058 => 248059)
--- branches/safari-608-branch/Source/WebCore/ChangeLog 2019-07-31 20:56:18 UTC (rev 248058)
+++ branches/safari-608-branch/Source/WebCore/ChangeLog 2019-07-31 20:56:20 UTC (rev 248059)
@@ -1,5 +1,40 @@
2019-07-31 Alan Coon <[email protected]>
+ Cherry-pick r247915. rdar://problem/53764061
+
+ Force Reveal to always lookup from menu
+ https://bugs.webkit.org/show_bug.cgi?id=200186
+ <rdar://problem/52967940>
+
+ Reviewed by Tim Horton.
+
+ We currently only have the 'lookup' menu item, so we should always force the 'lookup' action from it.
+
+ Reveal is not currently testable.
+
+ * editing/cocoa/DictionaryLookup.mm:
+ (WebCore::showPopupOrCreateAnimationController):
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247915 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-07-29 Megan Gardner <[email protected]>
+
+ Force Reveal to always lookup from menu
+ https://bugs.webkit.org/show_bug.cgi?id=200186
+ <rdar://problem/52967940>
+
+ Reviewed by Tim Horton.
+
+ We currently only have the 'lookup' menu item, so we should always force the 'lookup' action from it.
+
+ Reveal is not currently testable.
+
+ * editing/cocoa/DictionaryLookup.mm:
+ (WebCore::showPopupOrCreateAnimationController):
+
+2019-07-31 Alan Coon <[email protected]>
+
Cherry-pick r247912. rdar://problem/53764200
REGRESSION (r246899): Subtitles show twice when controls show/hide on hulu.com
Modified: branches/safari-608-branch/Source/WebCore/editing/cocoa/DictionaryLookup.mm (248058 => 248059)
--- branches/safari-608-branch/Source/WebCore/editing/cocoa/DictionaryLookup.mm 2019-07-31 20:56:18 UTC (rev 248058)
+++ branches/safari-608-branch/Source/WebCore/editing/cocoa/DictionaryLookup.mm 2019-07-31 20:56:20 UTC (rev 248059)
@@ -491,7 +491,7 @@
if (createAnimationController)
return [presenter animationControllerForItem:item.get() documentContext:nil presentingContext:context.get() options:nil];
- [presenter revealItem:item.get() documentContext:nil presentingContext:context.get() options:nil];
+ [presenter revealItem:item.get() documentContext:nil presentingContext:context.get() options:@{ @"forceLookup": @YES }];
return nil;
#elif PLATFORM(MACCATALYST)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
