Title: [248070] branches/safari-608-branch/Source/WebKit
- Revision
- 248070
- Author
- [email protected]
- Date
- 2019-07-31 13:56:52 -0700 (Wed, 31 Jul 2019)
Log Message
Cherry-pick r248038. rdar://problem/53764075
AX: com.apple.WebKit.WebContent at com.apple.WebKit: -[WKAccessibilityWebPageObject accessibilityParameterizedAttributeNames]
https://bugs.webkit.org/show_bug.cgi?id=200277
<rdar://problem/49475009>
Reviewed by Per Arne Vollan.
Verify Page is available before calling into it.
* WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:
(-[WKAccessibilityWebPageObject ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-608-branch/Source/WebKit/ChangeLog (248069 => 248070)
--- branches/safari-608-branch/Source/WebKit/ChangeLog 2019-07-31 20:56:49 UTC (rev 248069)
+++ branches/safari-608-branch/Source/WebKit/ChangeLog 2019-07-31 20:56:52 UTC (rev 248070)
@@ -1,5 +1,36 @@
2019-07-31 Alan Coon <[email protected]>
+ Cherry-pick r248038. rdar://problem/53764075
+
+ AX: com.apple.WebKit.WebContent at com.apple.WebKit: -[WKAccessibilityWebPageObject accessibilityParameterizedAttributeNames]
+ https://bugs.webkit.org/show_bug.cgi?id=200277
+ <rdar://problem/49475009>
+
+ Reviewed by Per Arne Vollan.
+
+ Verify Page is available before calling into it.
+
+ * WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:
+ (-[WKAccessibilityWebPageObject ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-07-31 Chris Fleizach <[email protected]>
+
+ AX: com.apple.WebKit.WebContent at com.apple.WebKit: -[WKAccessibilityWebPageObject accessibilityParameterizedAttributeNames]
+ https://bugs.webkit.org/show_bug.cgi?id=200277
+ <rdar://problem/49475009>
+
+ Reviewed by Per Arne Vollan.
+
+ Verify Page is available before calling into it.
+
+ * WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:
+ (-[WKAccessibilityWebPageObject ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
+
+2019-07-31 Alan Coon <[email protected]>
+
Cherry-pick r248015. rdar://problem/53764191
Can't scroll on yummly.co.uk recipe (scale(0) div covers the content and hit-tests)
Modified: branches/safari-608-branch/Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm (248069 => 248070)
--- branches/safari-608-branch/Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm 2019-07-31 20:56:49 UTC (rev 248069)
+++ branches/safari-608-branch/Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm 2019-07-31 20:56:52 UTC (rev 248070)
@@ -96,9 +96,13 @@
{
return retrieveAccessibilityValueFromMainThread<id>([&self] () -> id {
NSMutableArray *names = [NSMutableArray array];
- auto result = m_page->corePage()->pageOverlayController().copyAccessibilityAttributesNames(true);
- for (auto& name : result)
- [names addObject:(NSString *)name];
+ if (!m_page)
+ return names;
+
+ if (auto corePage = m_page->corePage()) {
+ for (auto& name : corePage->pageOverlayController().copyAccessibilityAttributesNames(true))
+ [names addObject:(NSString *)name];
+ }
return names;
});
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
