Title: [248076] trunk/Tools
Revision
248076
Author
[email protected]
Date
2019-07-31 15:21:29 -0700 (Wed, 31 Jul 2019)

Log Message

results.webkit.og: Timeline in canvas painting with wrong colors, cannot customize scale
https://bugs.webkit.org/show_bug.cgi?id=200318

Reviewed by Aakash Jain.

* resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
(Timeline.CanvasSeriesComponent): Reset draw context between dots.
(Timeline.CanvasXAxisComponent): Use getLabel function.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (248075 => 248076)


--- trunk/Tools/ChangeLog	2019-07-31 21:36:59 UTC (rev 248075)
+++ trunk/Tools/ChangeLog	2019-07-31 22:21:29 UTC (rev 248076)
@@ -1,3 +1,14 @@
+2019-07-31  Jonathan Bedard  <[email protected]>
+
+        results.webkit.og: Timeline in canvas painting with wrong colors, cannot customize scale
+        https://bugs.webkit.org/show_bug.cgi?id=200318
+
+        Reviewed by Aakash Jain.
+
+        * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
+        (Timeline.CanvasSeriesComponent): Reset draw context between dots.
+        (Timeline.CanvasXAxisComponent): Use getLabel function.
+
 2019-07-31  Loïc Yhuel  <[email protected]>
 
         [GTK][WPE] Fix gtkdoc build with "build-webkit --32-bit" on 64-bit hosts

Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js (248075 => 248076)


--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js	2019-07-31 21:36:59 UTC (rev 248075)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js	2019-07-31 22:21:29 UTC (rev 248076)
@@ -209,6 +209,7 @@
         emptylineColor = emptylineColor ? emptylineColor : defaultEmptyLineColor;
             if (!isEmpty) {
                 //Draw the dot
+                context.beginPath();
                 context.arc(x + dotMargin + radius, y, radius, 0, 2 * Math.PI);
                 context.fillStyle = color;
                 context.fill();
@@ -560,10 +561,10 @@
         context.save();
         if (!isTop) {
             context.rotate(fontRotate);
-            context.fillText(scaleLabel, middlePointX / 2 + sqrt3 * scaleTagLineHeight / 2, baseLineY - sqrt3 * (middlePointX / 2) + scaleTagLineHeight / 2);
+            context.fillText(getLabel(scaleLabel), middlePointX / 2 + sqrt3 * scaleTagLineHeight / 2, baseLineY - sqrt3 * (middlePointX / 2) + scaleTagLineHeight / 2);
         } else {
             context.rotate(fontTopRotate);
-            context.fillText(scaleLabel, middlePointX / 2 - sqrt3 * scaleTagLineHeight - fontSizeNumber, baseLineY + sqrt3 * (middlePointX / 2) -    3 * scaleTagLineHeight / 2 - fontSizeNumber);
+            context.fillText(getLabel(scaleLabel), middlePointX / 2 - sqrt3 * scaleTagLineHeight - fontSizeNumber, baseLineY + sqrt3 * (middlePointX / 2) -    3 * scaleTagLineHeight / 2 - fontSizeNumber);
         }
         context.restore();
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to