Title: [248156] trunk/Source/ThirdParty/libwebrtc
Revision
248156
Author
[email protected]
Date
2019-08-02 10:04:15 -0700 (Fri, 02 Aug 2019)

Log Message

Add build check for libwebrtc ObjectiveC names
https://bugs.webkit.org/show_bug.cgi?id=200365

Reviewed by Eric Carlson.

Only allow ObjectiveC names starting with WK_RTC.

* libwebrtc.xcodeproj/project.pbxproj:

Modified Paths

Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (248155 => 248156)


--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2019-08-02 16:43:56 UTC (rev 248155)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2019-08-02 17:04:15 UTC (rev 248156)
@@ -1,3 +1,14 @@
+2019-08-02  Youenn Fablet  <[email protected]>
+
+        Add build check for libwebrtc ObjectiveC names
+        https://bugs.webkit.org/show_bug.cgi?id=200365
+
+        Reviewed by Eric Carlson.
+
+        Only allow ObjectiveC names starting with WK_RTC.
+
+        * libwebrtc.xcodeproj/project.pbxproj:
+
 2019-08-01  Loïc Yhuel  <[email protected]>
 
         Fix libwebrtc build with Linux 5.2 headers

Modified: trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj (248155 => 248156)


--- trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj	2019-08-02 16:43:56 UTC (rev 248155)
+++ trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj	2019-08-02 17:04:15 UTC (rev 248156)
@@ -15299,6 +15299,7 @@
 				FB39D0CE1200F0E300088E69 /* Sources */,
 				FB39D0CF1200F0E300088E69 /* Frameworks */,
 				5CD286461E6E154E0094FDC8 /* Check for Weak VTables and Externals */,
+				41F2354122F39AC000B4FCDB /* Check For Inappropriate Objective-C Class Names */,
 				312BDB0B15FECAB00097EBC7 /* CopyFiles */,
 				312BDB0D15FECACE0097EBC7 /* CopyFiles */,
 			);
@@ -15368,6 +15369,25 @@
 /* End PBXProject section */
 
 /* Begin PBXShellScriptBuildPhase section */
+		41F2354122F39AC000B4FCDB /* Check For Inappropriate Objective-C Class Names */ = {
+			isa = PBXShellScriptBuildPhase;
+			buildActionMask = 2147483647;
+			files = (
+			);
+			inputFileListPaths = (
+			);
+			inputPaths = (
+				"$(TARGET_BUILD_DIR)/$(EXECUTABLE_PATH)",
+			);
+			name = "Check For Inappropriate Objective-C Class Names";
+			outputFileListPaths = (
+			);
+			outputPaths = (
+			);
+			runOnlyForDeploymentPostprocessing = 0;
+			shellPath = /bin/sh;
+			shellScript = "#if [ \"${ACTION}\" = \"installhdrs\" -o \"${ACTION}\" = \"installapi\" ]; then\n#    exit 0;\n#fi\n\n#if [ -f ../../../Tools/Scripts/check-for-inappropriate-objc-class-names ]; then\n    ../../../Tools/Scripts/check-for-inappropriate-objc-class-names WK_RTC || exit $?\n#fi\n";
+		};
 		5C63F6661E414ABA002CA531 /* ShellScript */ = {
 			isa = PBXShellScriptBuildPhase;
 			buildActionMask = 2147483647;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to