Title: [248167] trunk/Source/WebCore
- Revision
- 248167
- Author
- [email protected]
- Date
- 2019-08-02 11:58:46 -0700 (Fri, 02 Aug 2019)
Log Message
[macOS, iOS] webaudio/silent-audio-interrupted-in-background.html sometimes crashes
https://bugs.webkit.org/show_bug.cgi?id=200396
<rdar://problem/53819720>
Reviewed by Youenn Fablet.
No new test, this fixes an existing test.
* platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
(WebCore::AudioSourceProviderAVFObjC::~AudioSourceProviderAVFObjC): Drop the
lock before clearing m_tapStorage.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (248166 => 248167)
--- trunk/Source/WebCore/ChangeLog 2019-08-02 18:49:58 UTC (rev 248166)
+++ trunk/Source/WebCore/ChangeLog 2019-08-02 18:58:46 UTC (rev 248167)
@@ -1,3 +1,17 @@
+2019-08-02 Eric Carlson <[email protected]>
+
+ [macOS, iOS] webaudio/silent-audio-interrupted-in-background.html sometimes crashes
+ https://bugs.webkit.org/show_bug.cgi?id=200396
+ <rdar://problem/53819720>
+
+ Reviewed by Youenn Fablet.
+
+ No new test, this fixes an existing test.
+
+ * platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
+ (WebCore::AudioSourceProviderAVFObjC::~AudioSourceProviderAVFObjC): Drop the
+ lock before clearing m_tapStorage.
+
2019-08-02 Youenn Fablet <[email protected]>
[iOS] Directly use RealtimeMediaSourceCenter to compute the media capture state
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm (248166 => 248167)
--- trunk/Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm 2019-08-02 18:49:58 UTC (rev 248166)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm 2019-08-02 18:58:46 UTC (rev 248167)
@@ -90,8 +90,9 @@
if (m_tapStorage) {
std::lock_guard<Lock> lock(m_tapStorage->mutex);
m_tapStorage->_this = nullptr;
- m_tapStorage = nullptr;
}
+
+ m_tapStorage = nullptr;
}
void AudioSourceProviderAVFObjC::provideInput(AudioBus* bus, size_t framesToProcess)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
