Title: [248174] trunk/Source/WebKit
- Revision
- 248174
- Author
- [email protected]
- Date
- 2019-08-02 13:09:06 -0700 (Fri, 02 Aug 2019)
Log Message
[iPadOS] slides.google.com: Full Screen API warning is presented when swiping through slides
https://bugs.webkit.org/show_bug.cgi?id=200313
<rdar://problem/53777001>
Reviewed by Eric Carlson.
Only run the secheuristic scoring during UIGestureRecognizerStateEnded, rather than both
UIGestureRecognizerStateEnded and UIGestureRecognizerStateBegan. The goal of the heuristic is
to detect fake on-screen keyboards by detecting gestures that look like "typing". Using only
UIGestureRecognizerStateEnded still allows us to do this (as typing will usually have identical
geometries for both Ended and Began) without generating false-positives during swipe gestures.
* UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController _touchDetected:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (248173 => 248174)
--- trunk/Source/WebKit/ChangeLog 2019-08-02 20:07:11 UTC (rev 248173)
+++ trunk/Source/WebKit/ChangeLog 2019-08-02 20:09:06 UTC (rev 248174)
@@ -1,3 +1,20 @@
+2019-08-02 Jer Noble <[email protected]>
+
+ [iPadOS] slides.google.com: Full Screen API warning is presented when swiping through slides
+ https://bugs.webkit.org/show_bug.cgi?id=200313
+ <rdar://problem/53777001>
+
+ Reviewed by Eric Carlson.
+
+ Only run the secheuristic scoring during UIGestureRecognizerStateEnded, rather than both
+ UIGestureRecognizerStateEnded and UIGestureRecognizerStateBegan. The goal of the heuristic is
+ to detect fake on-screen keyboards by detecting gestures that look like "typing". Using only
+ UIGestureRecognizerStateEnded still allows us to do this (as typing will usually have identical
+ geometries for both Ended and Began) without generating false-positives during swipe gestures.
+
+ * UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
+ (-[WKFullScreenViewController _touchDetected:]):
+
2019-08-02 Wenson Hsieh <[email protected]>
[macOS 10.15] Image dragged from Safari does not appear in Notes
Modified: trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm (248173 => 248174)
--- trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm 2019-08-02 20:07:11 UTC (rev 248173)
+++ trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm 2019-08-02 20:09:06 UTC (rev 248174)
@@ -529,7 +529,7 @@
- (void)_touchDetected:(id)sender
{
- if ([_touchGestureRecognizer state] == UIGestureRecognizerStateBegan || [_touchGestureRecognizer state] == UIGestureRecognizerStateEnded) {
+ if ([_touchGestureRecognizer state] == UIGestureRecognizerStateEnded) {
double score = _secheuristic.scoreOfNextTouch([_touchGestureRecognizer locationInView:self.view]);
if (score > requiredScore)
[self _showPhishingAlert];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
