Title: [248189] trunk/LayoutTests
- Revision
- 248189
- Author
- [email protected]
- Date
- 2019-08-02 16:20:31 -0700 (Fri, 02 Aug 2019)
Log Message
[ Mac ] Layout Test accessibility/mac/press-not-work-for-disabled-menu-list.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=196505
<rdar://problem/49532620>
Patch by Andres Gonzalez <[email protected]> on 2019-08-02
Reviewed by Chris Fleizach.
Re-wrote test in a timing independent way. This should fix the intermittent failures.
* accessibility/mac/press-not-work-for-disabled-menu-list.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (248188 => 248189)
--- trunk/LayoutTests/ChangeLog 2019-08-02 23:03:06 UTC (rev 248188)
+++ trunk/LayoutTests/ChangeLog 2019-08-02 23:20:31 UTC (rev 248189)
@@ -1,3 +1,14 @@
+2019-08-02 Andres Gonzalez <[email protected]>
+
+ [ Mac ] Layout Test accessibility/mac/press-not-work-for-disabled-menu-list.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=196505
+ <rdar://problem/49532620>
+
+ Reviewed by Chris Fleizach.
+
+ Re-wrote test in a timing independent way. This should fix the intermittent failures.
+ * accessibility/mac/press-not-work-for-disabled-menu-list.html:
+
2019-08-02 Yury Semikhatsky <[email protected]>
Web Inspector: Crash when interacting with Template Content in Console
Modified: trunk/LayoutTests/accessibility/mac/press-not-work-for-disabled-menu-list.html (248188 => 248189)
--- trunk/LayoutTests/accessibility/mac/press-not-work-for-disabled-menu-list.html 2019-08-02 23:03:06 UTC (rev 248188)
+++ trunk/LayoutTests/accessibility/mac/press-not-work-for-disabled-menu-list.html 2019-08-02 23:20:31 UTC (rev 248189)
@@ -42,35 +42,34 @@
description("This tests that menu lists that are disabled will not be triggered by AXPress actions.");
// We don't test for enabled controls because opening menu lists waits on the UI process to display the menu.
- var numOfTests = 3, notificationCount = 0;
+ var testCount = 3, testIndex = 0;
var lists = [null, null, null];
- if (window.accessibilityController) {
- jsTestIsAsync = true;
- pressNext(0);
- }
- function pressNext(testId) {
- if (testId > numOfTests)
+ function testNextList() {
+ if (testIndex >= testCount) {
+ finishJSTest();
return;
- var menulist = accessibilityController.accessibleElementById("test" + testId);
+ }
+
+ var menulist = accessibilityController.accessibleElementById("test" + testIndex);
menulist.addNotificationListener(pressListener);
menulist.press();
- lists[testId] = menulist;
- window.setTimeout(function() {
- pressNext(testId + 1);
- }, 0);
+ lists[testIndex] = menulist;
}
function pressListener(notification) {
- if (notification == "AXPressDidFail" || notification == "AXPressDidSucceed")
- notificationCount++;
+ lists[testIndex].removeNotificationListener(pressListener);
debug("Got notification: " + notification);
- lists[notificationCount-1].removeNotificationListener(pressListener);
- if (notificationCount == numOfTests) {
- finishJSTest();
- }
+
+ testIndex++;
+ testNextList();
}
+
+ if (window.accessibilityController) {
+ jsTestIsAsync = true;
+ testNextList();
+ }
</script>
<script src=""
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
